-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix portable-atomic on wgpu-hal
#7735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
Co-Authored-By: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
portable-atomic on wgpu-hal
For atomic compatibility, users must enable `once_cell/portable-atomic` on their own.
Wumpf
approved these changes
Jun 25, 2025
Member
Wumpf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
Member
|
let's merge after conflict resolve (+ green ci) |
sharmajai
pushed a commit
to sharmajai/wgpu
that referenced
this pull request
Oct 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
no_stdsupport #7599Description
wgpu-halhas aportable-atomicfeature, butalloc::sync::Arcis unconditionally used, causing a compilation failure onthumbv6m-none-eabi, as this target does not support atomic pointers. This can be almost trivially resolved by usingportable-atomic-util, which provides an API-compatibleArcbased onportable-atomic.Note that while WGPU does not support
thumbv6m-none-eabi(and it is not tested in CI), I am using it to represent targets without atomic pointers that the project may wish to support in the future.Also note that this PR is branched from #7599, as
no_stdsupport is required to test the atomics failure condition. Once #7599 is merged, this PR will reduce to its most recent commit.Finally, to ensure
portable-atomicis kept out of the dependency graph, it is up to users to enableonce_cell/portable-atomicon their own when required.Testing
thumbv6m-none-eabiSquash or Rebase?
Squash
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.If this contains user-facing changes, add aN/ACHANGELOG.mdentry.