-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[wgpu-hal]: MVP no_std support
#7599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CI / Clippy WASM Core 1.0 is an expected failure while #7585 is not merged. |
cwfitzgerald
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some very minor things, but g2g after those :)
cwfitzgerald
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong button :)
Co-Authored-By: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
|
Should be good to go now! |
|
Could you do that transform on the other backends which have a validation canary, as well - forgot to note them. |
Co-Authored-By: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
* MVP `no_std` support in `wgpu-hal` * Update CHANGELOG.md * Fix visibility * Fix unused imports * Response to feedback Co-Authored-By: Connor Fitzgerald <connorwadefitzgerald@gmail.com> * Update other `validation_canary` usages Co-Authored-By: Connor Fitzgerald <connorwadefitzgerald@gmail.com> --------- Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
Connections
no_stdpolyfill forround_ties_evenforf32andf64#7585Description
wgpu-typeswhen used as a workspace dependency, and then re-enable in affected crates.wgpu-halto theno_stdCI task.parking_lotinwgpu-halto only the features that actually use it.wgpu-hal,validation_canary, which controls the compilation of theVALIDATION_CANARYstatic, and only enable it inwgpu-tests. This was the only unconditional use ofparking_lotinwgpu-hal, and since it's an internal debugging feature, I believe it makes sense to feature-gate it as such.Testing
Squash or Rebase?
Squash
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.