Merge pull request #56 from danilopopeye/feature/handle-create-user-response

gfleury · web-flow · commit ae4ad57f4f03 · 2020-08-10T14:57:49.000+02:00
handle `CreateUser` empty body response
diff --git a/default_api.go b/default_api.go
@@ -1264,7 +1264,8 @@ func (a *DefaultApiService) CreateUser(localVarOptionals map[string]interface{})
 		return NewAPIResponseWithError(localVarHTTPResponse, bodyBytes, reportError("Status: %v, Body: %s", localVarHTTPResponse.Status, bodyBytes))
 	}
 
-	return NewBitbucketAPIResponse(localVarHTTPResponse)
+	// No body parsing (a successful 204 response has no content)
+	return NewAPIResponse(localVarHTTPResponse), nil
 }
 
 /* DefaultApiService
diff --git a/default_api_test.go b/default_api_test.go
@@ -1003,6 +1003,7 @@ func TestDefaultApiService_CreateUser(t *testing.T) {
 		wantErr, integrationTest bool
 	}{
 		{"networkErrorContextExceeded", fields{client: generateConfigFake()}, args{}, &APIResponse{Message: "Post https://stash.domain.com/rest/api/1.0/admin/users: context canceled"}, true, false},
+		{"GoodUser", fields{client: generateConfigFake()}, args{localVarOptionals: map[string]interface{}{"name": "username"}}, &APIResponse{Message: "Post https://stash.domain.com/rest/api/1.0/admin/users?name=username: context canceled"}, true, false},
 	}
 	for _, tt := range tests {
 		if tt.integrationTest != runIntegrationTests {

Original file line number	Diff line number	Diff line change
`@@ -1264,7 +1264,8 @@ func (a *DefaultApiService) CreateUser(localVarOptionals map[string]interface{})`
`1264`	`1264`	`return NewAPIResponseWithError(localVarHTTPResponse, bodyBytes, reportError("Status: %v, Body: %s", localVarHTTPResponse.Status, bodyBytes))`
`1265`	`1265`	`}`
`1266`	`1266`
`1267`		`- return NewBitbucketAPIResponse(localVarHTTPResponse)`
	`1267`	`+ // No body parsing (a successful 204 response has no content)`
	`1268`	`+ return NewAPIResponse(localVarHTTPResponse), nil`
`1268`	`1269`	`}`
`1269`	`1270`
`1270`	`1271`	`/* DefaultApiService`
Original file line number	Diff line number	Diff line change
`@@ -1003,6 +1003,7 @@ func TestDefaultApiService_CreateUser(t *testing.T) {`
`1003`	`1003`	`wantErr, integrationTest bool`
`1004`	`1004`	`}{`
`1005`	`1005`	`{"networkErrorContextExceeded", fields{client: generateConfigFake()}, args{}, &APIResponse{Message: "Post https://stash.domain.com/rest/api/1.0/admin/users: context canceled"}, true, false},`
	`1006`	`+ {"GoodUser", fields{client: generateConfigFake()}, args{localVarOptionals: map[string]interface{}{"name": "username"}}, &APIResponse{Message: "Post https://stash.domain.com/rest/api/1.0/admin/users?name=username: context canceled"}, true, false},`
`1006`	`1007`	`}`
`1007`	`1008`	`for _, tt := range tests {`
`1008`	`1009`	`if tt.integrationTest != runIntegrationTests {`