split eslint stuff into client (v9) & server (v8 still)

Author: ryan953

.eslintrc.json

@@ -24,7 +24,7 @@ test: test-install
 test-install: echo-exports
 	npm install --legacy-peer-deps
 	npm install --legacy-peer-deps --prefix ./server
-	npm install --legacy-peer-deps --prefix ./client
+	npm install --prefix ./client
 
 # Launch a local development server for working on the
 # React www app (points at deployed/production validation fn)

Makefile

@@ -0,0 +1,28 @@
+{
+  "extends": [
+    "../.eslintrc.json",
+    "plugin:react/recommended"
+  ],
+  "plugins": [
+    "react"
+  ],
+  "parserOptions": {
+    "sourceType": "module",
+    "ecmaVersion": 6,
+    "ecmaFeatures": {
+      "jsx": true
+    }
+  },
+  "env": {
+    "es6": true,
+    "browser": true,
+    "jest": true
+  },
+  "globals": {
+    "React": false
+  },
+  "rules": {
+     "react/jsx-uses-vars": 1,
+     "arrow-parens": ["error", "as-needed"]
+  }
+}

client/.eslintrc.json

@@ -1,3 +1,19 @@
+# dependencies
+/node_modules
+
+# testing
+/coverage
+
+# production
+/build
+
+# misc
+.DS_Store
+.env.local
+.env.development.local
+.env.test.local
+.env.production.local
+
 # Logs
 logs
 *.log

client/.gitignore

@@ -47,7 +47,6 @@ function registerValidSW(swUrl) {
   navigator.serviceWorker
     .register(swUrl)
     .then(registration => {
-      // eslint-disable-next-line no-param-reassign
       registration.onupdatefound = () => {
         const installingWorker = registration.installing;
         installingWorker.onstatechange = () => {
@@ -57,21 +56,18 @@ function registerValidSW(swUrl) {
               // the fresh content will have been added to the cache.
               // It's the perfect time to display a "New content is
               // available; please refresh." message in your web app.
-              // eslint-disable-next-line no-console
               console.log('New content is available; please refresh.');
             } else {
               // At this point, everything has been precached.
               // It's the perfect time to display a
               // "Content is cached for offline use." message.
-              // eslint-disable-next-line no-console
               console.log('Content is cached for offline use.');
             }
           }
         };
       };
     })
     .catch(error => {
-      // eslint-disable-next-line no-console
       console.error('Error during service worker registration:', error);
     });
 }
@@ -97,7 +93,6 @@ function checkValidServiceWorker(swUrl) {
       }
     })
     .catch(() => {
-      // eslint-disable-next-line no-console
       console.log(
         'No internet connection found. App is running in offline mode.'
       );

client/src/assets/react.svg

@@ -64,7 +64,7 @@ export default function Home() {
         navigate(`/report/${reportName}`);
       });
     });
-  }, []);
+  }, [navigate, targetUrl]);
 
   if (isLoading) {
     return <Loader />;

client/src/registerServiceWorker.js

@@ -149,7 +149,7 @@ export default function Report() {
   useEffect(() => {
     const reportUrl = `${STORAGE_URL}/${encodeURIComponent(reportName ?? '')}`;
     fetch(reportUrl).then(response => response.json()).then(setReport);
-  }, [report]);
+  }, [report, reportName]);
 
   if (!report) {
     return <Loader />;

client/src/views/Home.tsx

@@ -1,9 +1,6 @@
 {
   "devDependencies": {
     "@testing-library/react": "^13.1.1",
-    "eslint": "^8.57.1",
-    "eslint-config-airbnb-base": "^15.0.0",
-    "eslint-plugin-react": "^7.37.1",
     "jest": "^24.9.0",
     "lint-staged": "^15.2.10",
     "prettier": "^1.19.1",
@@ -22,6 +19,12 @@
       "cd server && npm build",
       "eslint --fix",
       "git add"
+    ],
+    "*.ts": [
+      "prettier --write \"server/src/**/*.{js,ts}\"",
+      "cd server && npm build",
+      "eslint --fix",
+      "git add"
     ]
   },
   "prettier": {

client/src/views/Report.tsx

@@ -1,10 +1,31 @@
 {
-  "extends": "../.eslintrc.json",
+  "extends": "airbnb-base",
   "env": {
     "node": true,
     "jest": true
   },
   "rules": {
-    "import/no-extraneous-dependencies": ["error", {"devDependencies": true}]
+    "global-require": 0,
+    "object-curly-spacing": 0,
+    "no-use-before-define": 0,
+    "no-plusplus": 0,
+    "import/no-extraneous-dependencies": ["error", {"devDependencies": true}],
+    "comma-dangle": ["error", {
+      "arrays": "ignore",
+      "functions": "ignore"
+    }],
+    "func-names": 0,
+    "consistent-return": ["error", {"treatUndefinedAsUnspecified": true}],
+    "no-void": 0,
+    "class-methods-use-this" : 0,
+    "max-len": 0,
+    "arrow-body-style": 0
+  },
+  "settings": {
+    "import/resolver": {
+      "node": {
+        "extensions": [".js", ".jsx", ".ts", ".tsx"]
+      }
+    }
   }
-}
+}