From 89295fe257cd94b817407030e66f2ce2f796ac1e Mon Sep 17 00:00:00 2001 From: Josh Ferge Date: Sun, 9 Nov 2025 23:38:29 -0500 Subject: [PATCH] fix(types): Validate issueId in installation external issues endpoint Add validation to ensure issueId is provided, returning 400 error if missing before querying the Group model. --- .../api/endpoints/installation_external_issues.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/sentry/sentry_apps/api/endpoints/installation_external_issues.py b/src/sentry/sentry_apps/api/endpoints/installation_external_issues.py index 6aef63a5562bc1..7cf4b2c5e2cb8f 100644 --- a/src/sentry/sentry_apps/api/endpoints/installation_external_issues.py +++ b/src/sentry/sentry_apps/api/endpoints/installation_external_issues.py @@ -35,9 +35,13 @@ class SentryAppInstallationExternalIssuesEndpoint(ExternalIssueBaseEndpoint): def post(self, request: Request, installation) -> Response: data = request.data + issue_id = data.get("issueId") + if not issue_id: + raise SentryAppError(message="issueId is required", status_code=400) + try: group = Group.objects.get( - id=data.get("issueId"), + id=issue_id, project_id__in=Project.objects.filter(organization_id=installation.organization_id), ) except Group.DoesNotExist: