Skip to content

fix(types): Add assertions for project_id and organization_id validation #103022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix(types): Add assertions for project_id and organization_id validation #103022

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/sentry/api/endpoints/prompts_activity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,13 +93,17 @@ def put(self, request: Request, **kwargs):
# if project_id or organization_id in required fields make sure they exist
# if NOT in required fields, insert dummy value so dups aren't recorded
if "project_id" in required_fields:
if not Project.objects.filter(id=fields["project_id"]).exists():
project_id = fields["project_id"]
assert project_id is not None
if not Project.objects.filter(id=project_id).exists():
return Response({"detail": "Project no longer exists"}, status=400)
else:
fields["project_id"] = 0

if "organization_id" in required_fields:
if not Organization.objects.filter(id=fields["organization_id"]).exists():
organization_id = fields["organization_id"]
assert organization_id is not None
if not Organization.objects.filter(id=organization_id).exists():
return Response({"detail": "Organization no longer exists"}, status=400)
else:
fields["organization_id"] = 0
Expand Down
Loading