fix(types): Fix detector_id annotation collision in workflow serializer #103020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unnecessary select_related("detector") and add type: ignore for
detector_id annotation which collides with the existing model field name
but is needed for the grouped query result.
github-actions
bot
added
the
Scope: Backend
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #103020 +/- ##
===========================================
- Coverage 80.75% 80.64% -0.11%
===========================================
Files 9145 9140 -5
Lines 395020 392793 -2227
Branches 24968 24968
===========================================
- Hits 319002 316785 -2217
+ Misses 75617 75607 -10
Partials 401 401 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove unnecessary select_related("detector") and add type: ignore for detector_id annotation which collides with the existing model field name but is needed for the grouped query result.
Changes
.select_related("detector")which is not needed after.values()# type: ignore[no-redef]for unavoidable annotation name collisionTest plan