Skip to content

fix(tracemetrics): Hide unit rows for now #103012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 10, 2025
Merged

fix(tracemetrics): Hide unit rows for now #103012

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7edfe19
fix(tracemetrics): Hide unit rows for now
k-fish Nov 9, 2025
b75d199
tests
k-fish Nov 10, 2025
b37a4a9
Merge branch 'master' into fix/tracemetrics/dropdown-glitch-second
k-fish Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion static/app/views/explore/hooks/useMetricOptions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ function metricOptionsQueryKey({
field: [
TraceMetricKnownFieldKey.METRIC_NAME,
TraceMetricKnownFieldKey.METRIC_TYPE,
TraceMetricKnownFieldKey.METRIC_UNIT,
`count(${TraceMetricKnownFieldKey.METRIC_NAME})`,
],
query: searchValue.formatString(),
Expand Down
1 change: 0 additions & 1 deletion static/app/views/explore/metrics/metricToolbar/metricSelector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ export function MetricSelector({traceMetric}: {traceMetric: TraceMetric}) {
type: option[TraceMetricKnownFieldKey.METRIC_TYPE] as TraceMetricTypeValue,
}),
metricType: option[TraceMetricKnownFieldKey.METRIC_TYPE],
metricUnit: option[TraceMetricKnownFieldKey.METRIC_UNIT],
metricName: option[TraceMetricKnownFieldKey.METRIC_NAME],
trailingItems: (
<MetricTypeBadge metricType={option[TraceMetricKnownFieldKey.METRIC_TYPE]} />
Expand Down
Loading