From 7edfe19647ef86720abb0dc4eb5e24aa6fd4a028 Mon Sep 17 00:00:00 2001 From: Kev Date: Sun, 9 Nov 2025 16:23:52 -0500 Subject: [PATCH 1/2] fix(tracemetrics): Hide unit rows for now This hides unit information until we display it correctly. --- static/app/views/explore/hooks/useMetricOptions.tsx | 1 - .../app/views/explore/metrics/metricToolbar/metricSelector.tsx | 1 - 2 files changed, 2 deletions(-) diff --git a/static/app/views/explore/hooks/useMetricOptions.tsx b/static/app/views/explore/hooks/useMetricOptions.tsx index b104eac8212154..3c1d08448d1b4c 100644 --- a/static/app/views/explore/hooks/useMetricOptions.tsx +++ b/static/app/views/explore/hooks/useMetricOptions.tsx @@ -37,7 +37,6 @@ function metricOptionsQueryKey({ field: [ TraceMetricKnownFieldKey.METRIC_NAME, TraceMetricKnownFieldKey.METRIC_TYPE, - TraceMetricKnownFieldKey.METRIC_UNIT, `count(${TraceMetricKnownFieldKey.METRIC_NAME})`, ], query: searchValue.formatString(), diff --git a/static/app/views/explore/metrics/metricToolbar/metricSelector.tsx b/static/app/views/explore/metrics/metricToolbar/metricSelector.tsx index eaf69a3b73b554..6c0cf3c945d894 100644 --- a/static/app/views/explore/metrics/metricToolbar/metricSelector.tsx +++ b/static/app/views/explore/metrics/metricToolbar/metricSelector.tsx @@ -62,7 +62,6 @@ export function MetricSelector({traceMetric}: {traceMetric: TraceMetric}) { type: option[TraceMetricKnownFieldKey.METRIC_TYPE] as TraceMetricTypeValue, }), metricType: option[TraceMetricKnownFieldKey.METRIC_TYPE], - metricUnit: option[TraceMetricKnownFieldKey.METRIC_UNIT], metricName: option[TraceMetricKnownFieldKey.METRIC_NAME], trailingItems: ( From b75d1995dd4944f1bb14cf38e9714c8c042ef3f4 Mon Sep 17 00:00:00 2001 From: Kev Date: Mon, 10 Nov 2025 08:53:36 -0500 Subject: [PATCH 2/2] tests --- static/app/views/explore/hooks/useMetricOptions.spec.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/static/app/views/explore/hooks/useMetricOptions.spec.tsx b/static/app/views/explore/hooks/useMetricOptions.spec.tsx index c5ffdfc28e3dfb..eb3d21d903b4aa 100644 --- a/static/app/views/explore/hooks/useMetricOptions.spec.tsx +++ b/static/app/views/explore/hooks/useMetricOptions.spec.tsx @@ -63,7 +63,7 @@ describe('useMetricOptions', () => { match: [ MockApiClient.matchQuery({ dataset: DiscoverDatasets.TRACEMETRICS, - field: ['metric.name', 'metric.type', 'metric.unit', 'count(metric.name)'], + field: ['metric.name', 'metric.type', 'count(metric.name)'], referrer: 'api.explore.metric-options', }), ], @@ -112,7 +112,7 @@ describe('useMetricOptions', () => { expect.objectContaining({ query: expect.objectContaining({ dataset: 'tracemetrics', - field: ['metric.name', 'metric.type', 'metric.unit', 'count(metric.name)'], + field: ['metric.name', 'metric.type', 'count(metric.name)'], referrer: 'api.explore.metric-options', statsPeriod: '3d', }),