Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sentry/seer/explorer/index_data.py
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ def get_trace_for_transaction(transaction_name: str, project_id: int) -> TraceDa
],
orderby=["precise.start_ts"],
offset=0,
limit=5000,
limit=1000,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Incorrect Span Count Misleads Consumers

The total_spans field in the returned TraceData object is set to len(spans), but with the limit reduced to 1000, traces with more than 1000 spans will have an incorrect total_spans value that only reflects the number of fetched spans rather than the actual total. This misleads consumers like Seer and logging that rely on this metric.

Fix in Cursor Fix in Web

referrer=Referrer.SEER_RPC,
config=config,
sampling_mode="NORMAL",
Expand Down
Loading