Skip to content

Commit f291876

Browse files
authored
fix(tracemetrics): Hide unit rows for now (#103012)
This hides unit information until we display it correctly. Closes LOGS-502
1 parent 7d2dfdf commit f291876

File tree

3 files changed

+2
-4
lines changed

3 files changed

+2
-4
lines changed

static/app/views/explore/hooks/useMetricOptions.spec.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ describe('useMetricOptions', () => {
6363
match: [
6464
MockApiClient.matchQuery({
6565
dataset: DiscoverDatasets.TRACEMETRICS,
66-
field: ['metric.name', 'metric.type', 'metric.unit', 'count(metric.name)'],
66+
field: ['metric.name', 'metric.type', 'count(metric.name)'],
6767
referrer: 'api.explore.metric-options',
6868
}),
6969
],
@@ -112,7 +112,7 @@ describe('useMetricOptions', () => {
112112
expect.objectContaining({
113113
query: expect.objectContaining({
114114
dataset: 'tracemetrics',
115-
field: ['metric.name', 'metric.type', 'metric.unit', 'count(metric.name)'],
115+
field: ['metric.name', 'metric.type', 'count(metric.name)'],
116116
referrer: 'api.explore.metric-options',
117117
statsPeriod: '3d',
118118
}),

static/app/views/explore/hooks/useMetricOptions.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ function metricOptionsQueryKey({
3737
field: [
3838
TraceMetricKnownFieldKey.METRIC_NAME,
3939
TraceMetricKnownFieldKey.METRIC_TYPE,
40-
TraceMetricKnownFieldKey.METRIC_UNIT,
4140
`count(${TraceMetricKnownFieldKey.METRIC_NAME})`,
4241
],
4342
query: searchValue.formatString(),

static/app/views/explore/metrics/metricToolbar/metricSelector.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,6 @@ export function MetricSelector({traceMetric}: {traceMetric: TraceMetric}) {
6262
type: option[TraceMetricKnownFieldKey.METRIC_TYPE] as TraceMetricTypeValue,
6363
}),
6464
metricType: option[TraceMetricKnownFieldKey.METRIC_TYPE],
65-
metricUnit: option[TraceMetricKnownFieldKey.METRIC_UNIT],
6665
metricName: option[TraceMetricKnownFieldKey.METRIC_NAME],
6766
trailingItems: (
6867
<MetricTypeBadge metricType={option[TraceMetricKnownFieldKey.METRIC_TYPE]} />

0 commit comments

Comments
 (0)