Skip to content

Commit dee65bc

Browse files
authored
ref(querybuilder): Change metrics meta to use snuba params (#75064)
- This is part of the change to move everything to snuba params
1 parent 17943ca commit dee65bc

File tree

1 file changed

+11
-5
lines changed

1 file changed

+11
-5
lines changed

src/sentry/api/endpoints/organization_metrics_meta.py

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,12 @@ def get(self, request: Request, organization) -> Response:
3232
}
3333
try:
3434
# This will be used on the perf homepage and contains preset queries, allow global views
35-
params = self.get_snuba_params(request, organization, check_global_views=False)
35+
snuba_params, _ = self.get_snuba_dataclass(
36+
request, organization, check_global_views=False
37+
)
3638
except NoProjects:
3739
return Response(data)
38-
original_project_ids = params["project_id"].copy()
40+
original_project_ids = snuba_params.project_ids[:]
3941

4042
with handle_query_errors():
4143
count_has_txn = "count_has_transaction_name()"
@@ -46,7 +48,8 @@ def get(self, request: Request, organization) -> Response:
4648
count_null,
4749
count_has_txn,
4850
],
49-
params=params,
51+
params={},
52+
snuba_params=snuba_params,
5053
query=f"{count_null}:0 AND {count_has_txn}:>0",
5154
referrer="api.organization-events-metrics-compatibility.compatible",
5255
functions_acl=["count_null_transactions", "count_has_transaction_name"],
@@ -85,14 +88,17 @@ def get(self, request: Request, organization) -> Response:
8588
}
8689
try:
8790
# This will be used on the perf homepage and contains preset queries, allow global views
88-
params = self.get_snuba_params(request, organization, check_global_views=False)
91+
snuba_params, _ = self.get_snuba_dataclass(
92+
request, organization, check_global_views=False
93+
)
8994
except NoProjects:
9095
return Response(data)
9196

9297
with handle_query_errors():
9398
sum_metrics = metrics_performance.query(
9499
selected_columns=[COUNT_UNPARAM, COUNT_NULL, "count()"],
95-
params=params,
100+
params={},
101+
snuba_params=snuba_params,
96102
query="",
97103
referrer="api.organization-events-metrics-compatibility.sum_metrics",
98104
functions_acl=["count_unparameterized_transactions", "count_null_transactions"],

0 commit comments

Comments
 (0)