Skip to content

Commit dede3f9

Browse files
authored
feat(replays): Emit mobile replay outcomes (#74649)
Emitting replay video outcome for tracking purposes. Closes: getsentry/team-replay#452 Related: getsentry/relay#3847
1 parent 340ffca commit dede3f9

File tree

5 files changed

+17
-5
lines changed

5 files changed

+17
-5
lines changed

requirements-base.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ sentry-arroyo>=2.16.5
6565
sentry-kafka-schemas>=0.1.101
6666
sentry-ophio==0.2.7
6767
sentry-redis-tools>=0.1.7
68-
sentry-relay>=0.9.0
68+
sentry-relay>=0.9.1
6969
sentry-sdk>=2.11.0
7070
slack-sdk>=3.27.2
7171
snuba-sdk>=2.0.33

requirements-dev-frozen.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ sentry-forked-djangorestframework-stubs==3.15.0.post1
185185
sentry-kafka-schemas==0.1.101
186186
sentry-ophio==0.2.7
187187
sentry-redis-tools==0.1.7
188-
sentry-relay==0.9.0
188+
sentry-relay==0.9.1
189189
sentry-sdk==2.11.0
190190
sentry-usage-accountant==0.0.10
191191
simplejson==3.17.6

requirements-frozen.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ sentry-arroyo==2.16.5
126126
sentry-kafka-schemas==0.1.101
127127
sentry-ophio==0.2.7
128128
sentry-redis-tools==0.1.7
129-
sentry-relay==0.9.0
129+
sentry-relay==0.9.1
130130
sentry-sdk==2.11.0
131131
sentry-usage-accountant==0.0.10
132132
simplejson==3.17.6

src/sentry/replays/usecases/ingest/__init__.py

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,19 @@ def track_initial_segment_event(
176176
first_replay_received.send_robust(project=project, sender=Project)
177177

178178
# Replay videos are not billed for now.
179-
if not is_replay_video:
179+
if is_replay_video:
180+
track_outcome(
181+
org_id=org_id,
182+
project_id=project_id,
183+
key_id=key_id,
184+
outcome=Outcome.ACCEPTED,
185+
reason=None,
186+
timestamp=datetime.fromtimestamp(received, timezone.utc),
187+
event_id=replay_id,
188+
category=DataCategory.REPLAY_VIDEO,
189+
quantity=1,
190+
)
191+
else:
180192
track_outcome(
181193
org_id=org_id,
182194
project_id=project_id,

tests/sentry/replays/consumers/test_recording.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ def test_event_with_replay_video(self, track_outcome, mock_record, mock_onboardi
203203
user_id=self.organization.default_owner_id,
204204
)
205205

206-
assert not track_outcome.called
206+
assert track_outcome.called
207207

208208
@patch("sentry.models.OrganizationOnboardingTask.objects.record")
209209
@patch("sentry.analytics.record")

0 commit comments

Comments
 (0)