ref(workflow_engine): Remove DetectorLifeCycleHooks (#102990)

These hooks can be implemented by overriding the validator and hooking
into create / update / delete

Fixes [NEW-610: Provide way for detectors `after_update` hooks to have
knowledge of what
changed](https://linear.app/getsentry/issue/NEW-610/provide-way-for-detectors-after-update-hooks-to-have-knowledge-of-what)

Author: evanpurkhiser

src/sentry/workflow_engine/endpoints/organization_detector_details.py

@@ -35,7 +35,6 @@
 )
 from sentry.workflow_engine.endpoints.validators.utils import get_unknown_detector_type_error
 from sentry.workflow_engine.models import Detector
-from sentry.workflow_engine.types import DetectorLifeCycleHooks
 
 
 def get_detector_validator(
@@ -205,8 +204,6 @@ def delete(self, request: Request, organization: Organization, detector: Detecto
         )
         validator.delete()
 
-        DetectorLifeCycleHooks.on_pending_delete(detector)
-
         if detector.type == MetricIssue.slug:
             schedule_update_project_config(detector)
 

src/sentry/workflow_engine/endpoints/validators/base/detector.py

@@ -30,7 +30,7 @@
 )
 from sentry.workflow_engine.models.data_condition import DataCondition
 from sentry.workflow_engine.models.detector import enforce_config_schema
-from sentry.workflow_engine.types import DataConditionType, DetectorLifeCycleHooks
+from sentry.workflow_engine.types import DataConditionType
 
 
 @dataclass(frozen=True)
@@ -143,7 +143,6 @@ def update(self, instance: Detector, validated_data: dict[str, Any]):
             data=instance.get_audit_log_data(),
         )
 
-        DetectorLifeCycleHooks.on_after_update(instance)
         return instance
 
     def delete(self) -> None:
@@ -230,6 +229,4 @@ def create(self, validated_data):
                 data=detector.get_audit_log_data(),
             )
 
-            DetectorLifeCycleHooks.on_after_create(detector)
-
         return detector

src/sentry/workflow_engine/types.py

@@ -1,7 +1,6 @@
 from __future__ import annotations
 
 from abc import ABC, abstractmethod
-from collections.abc import Callable
 from dataclasses import dataclass, field
 from enum import IntEnum, StrEnum
 from typing import TYPE_CHECKING, Any, ClassVar, Generic, TypedDict, TypeVar
@@ -184,54 +183,8 @@ class SnubaQueryDataSourceType(TypedDict):
     event_types: list[SnubaQueryEventType]
 
 
-type DetectorLifeCycleHook = Callable[[Detector], None]
-
-
-@dataclass(frozen=True)
-class DetectorLifeCycleHooks:
-    """
-    The DetectorLifeCycleHooks allow for hooks to be added into different areas of the API.
-    These hooks are only invoked through the API, for changes that might be happening outside of the API,
-    it's recommended to use a signal to capture the model updates.
-
-    Args:
-        after_create:
-            This method is used as a callback after a detector is created. The first argument is the detector that was created.
-
-        before_delete:
-            This method is used in the deletion API for a detector, the callback will be invoked with the id for the detector
-            that is deleted.
-
-        after_update:
-           This method is used to access when a detector is updated in the API.
-    """
-
-    after_create: DetectorLifeCycleHook | None = None
-    pending_delete: DetectorLifeCycleHook | None = None
-    after_update: DetectorLifeCycleHook | None = None
-
-    @staticmethod
-    def on_after_create(detector: Detector):
-        hooks = detector.settings.hooks
-        if hooks and hooks.after_create:
-            hooks.after_create(detector)
-
-    @staticmethod
-    def on_after_update(detector: Detector):
-        hooks = detector.settings.hooks
-        if hooks and hooks.after_update:
-            hooks.after_update(detector)
-
-    @staticmethod
-    def on_pending_delete(detector: Detector):
-        hooks = detector.settings.hooks
-        if hooks and hooks.pending_delete:
-            hooks.pending_delete(detector)
-
-
 @dataclass(frozen=True)
 class DetectorSettings:
-    hooks: DetectorLifeCycleHooks | None = None
     handler: type[DetectorHandler] | None = None
     validator: type[BaseDetectorTypeValidator] | None = None
     config_schema: dict[str, Any] = field(default_factory=dict)

tests/sentry/workflow_engine/detectors/test_life_cycle_hooks.py

@@ -31,11 +31,7 @@
 )
 from sentry.workflow_engine.models.data_condition import Condition
 from sentry.workflow_engine.models.detector_workflow import DetectorWorkflow
-from sentry.workflow_engine.types import (
-    DetectorLifeCycleHooks,
-    DetectorPriorityLevel,
-    DetectorSettings,
-)
+from sentry.workflow_engine.types import DetectorPriorityLevel
 
 pytestmark = [pytest.mark.sentry_metrics, requires_snuba, requires_kafka]
 
@@ -761,29 +757,3 @@ def test_error_group_type(self) -> None:
                 event=audit_log.get_event_id("DETECTOR_REMOVE"),
                 actor=self.user,
             ).exists()
-
-    def test_detector_life_cycle_delete_hook(self) -> None:
-        detector_settings = DetectorSettings(
-            hooks=DetectorLifeCycleHooks(pending_delete=mock.Mock())
-        )
-
-        with mock.patch.object(
-            Detector, "settings", new_callable=mock.PropertyMock
-        ) as mock_settings:
-            mock_settings.return_value = detector_settings
-
-            with outbox_runner():
-                self.get_success_response(self.organization.slug, self.detector.id)
-
-            detector_settings.hooks.pending_delete.assert_called_with(self.detector)  # type: ignore[union-attr]
-
-    def test_detector_life_cycle__no_delete_hook(self) -> None:
-        detector_settings = DetectorSettings(hooks=DetectorLifeCycleHooks())
-
-        with mock.patch.object(
-            Detector, "settings", new_callable=mock.PropertyMock
-        ) as mock_settings:
-            mock_settings.return_value = detector_settings
-
-            with outbox_runner():
-                self.get_success_response(self.organization.slug, self.detector.id)