ref: fix reassignment of incorrect QuerySet types (#75158)

fixes a handful of errors once mypy checks model types

<!-- Describe your PR here. -->

Author: asottile-sentry

src/sentry/api/endpoints/project_releases.py

@@ -69,11 +69,9 @@ def get(self, request: Request, project) -> Response:
         if query:
             queryset = queryset.filter(version__icontains=query)
 
-        queryset = queryset.extra(select={"sort": "COALESCE(date_released, date_added)"})
-
         return self.paginate(
             request=request,
-            queryset=queryset,
+            queryset=queryset.extra(select={"sort": "COALESCE(date_released, date_added)"}),
             order_by="-sort",
             paginator_cls=OffsetPaginator,
             on_results=lambda x: serialize(

src/sentry/models/eventattachment.py

@@ -16,6 +16,7 @@
 from sentry.backup.scopes import RelocationScope
 from sentry.db.models import BoundedBigIntegerField, Model, region_silo_model, sane_repr
 from sentry.db.models.fields.bounded import BoundedIntegerField
+from sentry.db.models.manager.base_query_set import BaseQuerySet
 from sentry.models.files.utils import get_size_and_checksum, get_storage
 
 # Attachment file types that are considered a crash report (PII relevant)
@@ -31,8 +32,8 @@ def get_crashreport_key(group_id: int) -> str:
 
 
 def event_attachment_screenshot_filter(
-    queryset: models.QuerySet[EventAttachment],
-) -> models.QuerySet[EventAttachment]:
+    queryset: BaseQuerySet[EventAttachment],
+) -> BaseQuerySet[EventAttachment]:
     # Intentionally a hardcoded list instead of a regex since current usecases do not have more 3 screenshots
     return queryset.filter(
         name__in=[