Skip to content

Commit 69bf4f9

Browse files
authored
feat: sunset adding new appstore connect repos (#72202)
This removes the "Appstore connect" from the dropdown list. This is done to prepare for sunsetting the App Store Connect integration. Ref: #51994
1 parent 6be7c0a commit 69bf4f9

File tree

2 files changed

+1
-108
lines changed

2 files changed

+1
-108
lines changed

static/app/views/settings/projectDebugFiles/sources/customRepositories/index.spec.tsx

Lines changed: 1 addition & 103 deletions
Original file line numberDiff line numberDiff line change
@@ -107,97 +107,6 @@ describe('Custom Repositories', function () {
107107
await import('sentry/components/modals/debugFileCustomRepository');
108108
});
109109

110-
it('renders', async function () {
111-
const props = getProps();
112-
113-
const {rerender} = render(<TestComponent {...props} />, {router: props.router});
114-
115-
// Section title
116-
expect(screen.getByText('Custom Repositories')).toBeInTheDocument();
117-
118-
// Enabled button
119-
expect(screen.getByText('Add Repository').closest('button')).toBeEnabled();
120-
121-
// Content
122-
expect(screen.getByText('No custom repositories configured')).toBeInTheDocument();
123-
124-
// Choose an App Store Connect source
125-
await userEvent.click(screen.getByText('Add Repository'));
126-
127-
await userEvent.click(screen.getByText('App Store Connect'));
128-
129-
// Display modal content
130-
// A single instance of App Store Connect is available on free plans
131-
expect(await screen.findByText('App Store Connect credentials')).toBeInTheDocument();
132-
133-
// Close Modal
134-
await userEvent.click(screen.getByLabelText('Close Modal'));
135-
136-
// Choose another source
137-
await userEvent.click(screen.getByText('Add Repository'));
138-
139-
await userEvent.click(screen.getByText('Amazon S3'));
140-
141-
// Feature disabled warning
142-
expect(
143-
await screen.findByText('This feature is not enabled on your Sentry installation.')
144-
).toBeInTheDocument();
145-
146-
// Help content
147-
expect(
148-
screen.getByText(
149-
"# Enables the Custom Symbol Sources feature SENTRY_FEATURES['custom-symbol-sources'] = True"
150-
)
151-
).toBeInTheDocument();
152-
153-
// Close Modal
154-
await userEvent.click(screen.getByLabelText('Close Modal'));
155-
156-
await waitFor(() => {
157-
expect(screen.queryByText('App Store Connect credentials')).not.toBeInTheDocument();
158-
});
159-
160-
// Renders disabled repository list
161-
rerender(
162-
<TestComponent
163-
{...props}
164-
customRepositories={[httpRepository, appStoreConnectRepository]}
165-
/>
166-
);
167-
168-
// Content
169-
const actions = screen.queryAllByLabelText('Actions');
170-
expect(actions).toHaveLength(2);
171-
172-
// HTTP Repository
173-
expect(screen.getByText(httpRepository.name)).toBeInTheDocument();
174-
expect(screen.getByText(DEBUG_SOURCE_TYPES.http)).toBeInTheDocument();
175-
expect(actions[0]).toBeDisabled();
176-
177-
// App Store Connect Repository
178-
expect(screen.getByText(appStoreConnectRepository.name)).toBeInTheDocument();
179-
expect(screen.getByText(DEBUG_SOURCE_TYPES.appStoreConnect)).toBeInTheDocument();
180-
expect(actions[1]).toBeEnabled();
181-
182-
// A new App Store Connect instance is not available on free plans
183-
// Choose an App Store Connect source
184-
await userEvent.click(screen.getByText('Add Repository'));
185-
186-
await userEvent.click(screen.getByRole('button', {name: 'App Store Connect'}));
187-
188-
// Feature disabled warning
189-
expect(
190-
await screen.findByText('This feature is not enabled on your Sentry installation.')
191-
).toBeInTheDocument();
192-
193-
// Help content
194-
expect(
195-
screen.getByText(
196-
"# Enables the App Store Connect Multiple feature SENTRY_FEATURES['app-store-connect-multiple'] = True"
197-
)
198-
).toBeInTheDocument();
199-
});
200-
201110
it('renders with custom-symbol-sources feature enabled', async function () {
202111
const props = getProps();
203112
const newOrganization = {...props.organization, features: ['custom-symbol-sources']};
@@ -253,7 +162,7 @@ describe('Custom Repositories', function () {
253162
expect(actions[1]).toBeEnabled();
254163
});
255164

256-
it('renders with app-store-connect-multiple feature enabled', async function () {
165+
it('renders with app-store-connect-multiple feature enabled', function () {
257166
const props = getProps();
258167

259168
const newOrganization = {
@@ -289,17 +198,6 @@ describe('Custom Repositories', function () {
289198

290199
// Enabled button
291200
expect(screen.getByText('Add Repository').closest('button')).toBeEnabled();
292-
293-
await userEvent.click(screen.getByText('Add Repository'));
294-
295-
await userEvent.click(screen.getByRole('button', {name: 'App Store Connect'}));
296-
297-
// Display modal content
298-
// A new App Store Connect instance is available
299-
expect(await screen.findByText('App Store Connect credentials')).toBeInTheDocument();
300-
301-
// Close Modal
302-
await userEvent.click(screen.getByLabelText('Close Modal'));
303201
});
304202

305203
it('renders with custom-symbol-sources and app-store-connect-multiple features enabled', function () {

static/app/views/settings/projectDebugFiles/sources/customRepositories/utils.tsx

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,6 @@ export const dropDownItems = [
2828
label: customRepoTypeLabel[CustomRepoType.HTTP],
2929
searchKey: t('http symbol server ssqp symstore symsrv'),
3030
},
31-
{
32-
value: CustomRepoType.APP_STORE_CONNECT,
33-
label: customRepoTypeLabel[CustomRepoType.APP_STORE_CONNECT],
34-
searchKey: t('apple store connect itunes ios'),
35-
},
3631
];
3732

3833
export function getRequestMessages(

0 commit comments

Comments
 (0)