Skip to content

Commit 58f5bb0

Browse files
fix(prevent): Allow members to edit pr review config (#102974)
The backend now allows members to edit the pr review config. Adjust the frontend to reflect this too
1 parent c11b2be commit 58f5bb0

File tree

1 file changed

+8
-32
lines changed

1 file changed

+8
-32
lines changed

static/app/views/prevent/preventAI/manageReposPanel.tsx

Lines changed: 8 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ import type {
1818
PreventAIFeatureConfigsByName,
1919
Sensitivity,
2020
} from 'sentry/types/prevent';
21-
import useOrganization from 'sentry/utils/useOrganization';
2221
import {usePreventAIGitHubConfig} from 'sentry/views/prevent/preventAI/hooks/usePreventAIConfig';
2322
import {useUpdatePreventAIFeature} from 'sentry/views/prevent/preventAI/hooks/useUpdatePreventAIFeature';
2423
import {getRepoNameWithoutOrg} from 'sentry/views/prevent/preventAI/utils';
@@ -70,13 +69,8 @@ function ManageReposPanel({
7069
allRepos = [],
7170
isEditingOrgDefaults,
7271
}: ManageReposPanelProps) {
73-
const organization = useOrganization();
7472
const {enableFeature, isLoading, error: updateError} = useUpdatePreventAIFeature();
7573

76-
const canEditSettings =
77-
organization.access.includes('org:write') ||
78-
organization.access.includes('org:admin');
79-
8074
const {
8175
data: githubConfigData,
8276
isPending: isLoadingConfig,
@@ -201,7 +195,7 @@ function ManageReposPanel({
201195
<Switch
202196
size="lg"
203197
checked={!doesUseOrgDefaults}
204-
disabled={isLoading || !canEditSettings}
198+
disabled={isLoading}
205199
onChange={async () => {
206200
await enableFeature({
207201
feature: 'use_org_defaults',
@@ -237,11 +231,7 @@ function ManageReposPanel({
237231
<Switch
238232
size="lg"
239233
checked={repoConfig.vanilla.enabled}
240-
disabled={
241-
isLoading ||
242-
!canEditSettings ||
243-
(!isEditingOrgDefaults && doesUseOrgDefaults)
244-
}
234+
disabled={isLoading || (!isEditingOrgDefaults && doesUseOrgDefaults)}
245235
onChange={async () => {
246236
const newValue = !repoConfig.vanilla.enabled;
247237
await enableFeature({
@@ -272,9 +262,7 @@ function ManageReposPanel({
272262
value={repoConfig.vanilla.sensitivity ?? 'medium'}
273263
options={sensitivityOptions}
274264
disabled={
275-
isLoading ||
276-
!canEditSettings ||
277-
(!isEditingOrgDefaults && doesUseOrgDefaults)
265+
isLoading || (!isEditingOrgDefaults && doesUseOrgDefaults)
278266
}
279267
onChange={async option =>
280268
await enableFeature({
@@ -316,11 +304,7 @@ function ManageReposPanel({
316304
<Switch
317305
size="lg"
318306
checked={repoConfig.bug_prediction.enabled}
319-
disabled={
320-
isLoading ||
321-
!canEditSettings ||
322-
(!isEditingOrgDefaults && doesUseOrgDefaults)
323-
}
307+
disabled={isLoading || (!isEditingOrgDefaults && doesUseOrgDefaults)}
324308
onChange={async () => {
325309
const newValue = !repoConfig.bug_prediction.enabled;
326310
await enableFeature({
@@ -351,9 +335,7 @@ function ManageReposPanel({
351335
value={repoConfig.bug_prediction.sensitivity ?? 'medium'}
352336
options={sensitivityOptions}
353337
disabled={
354-
isLoading ||
355-
!canEditSettings ||
356-
(!isEditingOrgDefaults && doesUseOrgDefaults)
338+
isLoading || (!isEditingOrgDefaults && doesUseOrgDefaults)
357339
}
358340
onChange={async option =>
359341
await enableFeature({
@@ -387,9 +369,7 @@ function ManageReposPanel({
387369
size="lg"
388370
checked={repoConfig.bug_prediction.triggers.on_ready_for_review}
389371
disabled={
390-
isLoading ||
391-
!canEditSettings ||
392-
(!isEditingOrgDefaults && doesUseOrgDefaults)
372+
isLoading || (!isEditingOrgDefaults && doesUseOrgDefaults)
393373
}
394374
onChange={async () => {
395375
const newValue =
@@ -422,9 +402,7 @@ function ManageReposPanel({
422402
repoConfig.bug_prediction.triggers.on_new_commit ?? false
423403
}
424404
disabled={
425-
isLoading ||
426-
!canEditSettings ||
427-
(!isEditingOrgDefaults && doesUseOrgDefaults)
405+
isLoading || (!isEditingOrgDefaults && doesUseOrgDefaults)
428406
}
429407
onChange={async () => {
430408
const newValue =
@@ -455,9 +433,7 @@ function ManageReposPanel({
455433
size="lg"
456434
checked={repoConfig.bug_prediction.triggers.on_command_phrase}
457435
disabled={
458-
isLoading ||
459-
!canEditSettings ||
460-
(!isEditingOrgDefaults && doesUseOrgDefaults)
436+
isLoading || (!isEditingOrgDefaults && doesUseOrgDefaults)
461437
}
462438
onChange={async () => {
463439
const newValue =

0 commit comments

Comments
 (0)