Skip to content

Commit 37c2de0

Browse files
priscilawebdevJesse-Box
authored andcommitted
ref(project-settings): Remove unused name field (#103060)
Follow-up of #102690
1 parent 569ea40 commit 37c2de0

File tree

3 files changed

+7
-31
lines changed

3 files changed

+7
-31
lines changed

static/app/components/forms/jsonForm.spec.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ describe('JsonForm', () => {
170170
});
171171

172172
describe('fields prop', () => {
173-
const jsonFormFields = [fields.name, fields.platform] as FieldObject[];
173+
const jsonFormFields = [fields.slug, fields.platform] as FieldObject[];
174174

175175
it('default', () => {
176176
render(<JsonForm fields={jsonFormFields} />);

static/app/data/forms/projectGeneralSettings.tsx

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -50,28 +50,24 @@ const StyledPlatformIcon = styled(PlatformIcon)`
5050
`;
5151

5252
export const fields = {
53-
name: {
54-
name: 'name',
53+
slug: {
54+
name: 'slug',
5555
type: 'string',
5656
required: true,
5757
label: t('Slug'),
58-
placeholder: t('my-awesome-project'),
5958
help: t('A unique ID used to identify this project'),
60-
transformInput: slugify,
61-
getData: (data: {name?: string}) => {
59+
transformInput: slugify as (str: string) => string,
60+
getData: (data: {slug?: string}) => {
6261
return {
63-
name: data.name,
64-
slug: data.name,
62+
slug: data.slug,
6563
};
6664
},
67-
6865
saveOnBlur: false,
6966
saveMessageAlertType: 'warning',
7067
saveMessage: t(
7168
"Changing a project's slug can break your build scripts! Please proceed carefully."
7269
),
7370
},
74-
7571
platform: {
7672
name: 'platform',
7773
type: 'select',

static/app/views/settings/projectGeneralSettings/index.tsx

Lines changed: 1 addition & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ import {handleXhrErrorResponse} from 'sentry/utils/handleXhrErrorResponse';
3737
import type {ApiQueryKey} from 'sentry/utils/queryClient';
3838
import {setApiQueryData, useQueryClient} from 'sentry/utils/queryClient';
3939
import recreateRoute from 'sentry/utils/recreateRoute';
40-
import slugify from 'sentry/utils/slugify';
4140
import useApi from 'sentry/utils/useApi';
4241
import {useLocation} from 'sentry/utils/useLocation';
4342
import {useNavigate} from 'sentry/utils/useNavigate';
@@ -312,25 +311,6 @@ export function ProjectGeneralSettings({project, onChangeSlug}: Props) {
312311
help: t('The unique identifier for this project. It cannot be modified.'),
313312
};
314313

315-
const slugField: FieldObject = {
316-
name: 'slug',
317-
type: 'string',
318-
required: true,
319-
label: t('Slug'),
320-
help: t('A unique ID used to identify this project'),
321-
transformInput: slugify as (str: string) => string,
322-
getData: (data: {slug?: string}) => {
323-
return {
324-
slug: data.slug,
325-
};
326-
},
327-
saveOnBlur: false,
328-
saveMessageAlertType: 'warning',
329-
saveMessage: t(
330-
"Changing a project's slug can break your build scripts! Please proceed carefully."
331-
),
332-
};
333-
334314
// Create filtered platform field without mutating the shared fields object
335315
const platformField = {
336316
...fields.platform,
@@ -357,7 +337,7 @@ export function ProjectGeneralSettings({project, onChangeSlug}: Props) {
357337
<JsonForm
358338
{...jsonFormProps}
359339
title={t('Project Details')}
360-
fields={[slugField, projectIdField, platformField]}
340+
fields={[fields.slug, projectIdField, platformField]}
361341
/>
362342
<JsonForm {...jsonFormProps} title={t('Email')} fields={[fields.subjectPrefix]} />
363343
</Form>

0 commit comments

Comments
 (0)