Skip to content

Commit 46f3245

Browse files
fix: use $NODE_BINARY in Xcode scripts to invoke Sentry CLI (#3493)
1 parent c81b735 commit 46f3245

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
- Fix `WITH_ENVIRONMENT` overwrite in `sentry-xcode-debug-files.sh` ([#3525](https://github.com/getsentry/sentry-react-native/pull/3525))
2727
- Sentry CLI 2.25.1 fixes background debug files uploads during Xcode builds ([#3486](https://github.com/getsentry/sentry-react-native/pull/3486))
2828
- Performance Tracing should be disabled by default ([#3533](https://github.com/getsentry/sentry-react-native/pull/3533))
29+
- Use `$NODE_BINARY` to execute Sentry CLI in Xcode scripts ([#3493](https://github.com/getsentry/sentry-react-native/pull/3493))
2930

3031
### Dependencies
3132

scripts/sentry-xcode-debug-files.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ EXTRA_ARGS="$SENTRY_CLI_EXTRA_ARGS $SENTRY_CLI_DEBUG_FILES_UPLOAD_EXTRA_ARGS $IN
2626
UPLOAD_DEBUG_FILES="\"$SENTRY_CLI_EXECUTABLE\" debug-files upload $EXTRA_ARGS \"$DWARF_DSYM_FOLDER_PATH\""
2727

2828
if [ "$SENTRY_DISABLE_AUTO_UPLOAD" != true ]; then
29-
/bin/sh -c "$UPLOAD_DEBUG_FILES"
29+
/bin/sh -c "\"$LOCAL_NODE_BINARY\" $UPLOAD_DEBUG_FILES"
3030
else
3131
echo "SENTRY_DISABLE_AUTO_UPLOAD=true, skipping debug files upload"
3232
fi

scripts/sentry-xcode.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ ARGS="$NO_AUTO_RELEASE $SENTRY_CLI_EXTRA_ARGS $SENTRY_CLI_RN_XCODE_EXTRA_ARGS"
2323
REACT_NATIVE_XCODE_WITH_SENTRY="\"$SENTRY_CLI_EXECUTABLE\" react-native xcode $ARGS \"$REACT_NATIVE_XCODE\""
2424

2525
if [ "$SENTRY_DISABLE_AUTO_UPLOAD" != true ]; then
26-
/bin/sh -c "$REACT_NATIVE_XCODE_WITH_SENTRY"
26+
/bin/sh -c "\"$LOCAL_NODE_BINARY\" $REACT_NATIVE_XCODE_WITH_SENTRY"
2727
else
2828
echo "SENTRY_DISABLE_AUTO_UPLOAD=true, skipping sourcemaps upload"
2929
/bin/sh -c "$REACT_NATIVE_XCODE"

0 commit comments

Comments
 (0)