Skip to content

misc(android): update native android sdk name #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 4, 2025
Merged

misc(android): update native android sdk name #353

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
39151ee
Add native android sdk name
buenaflor Apr 3, 2025
719fce3
Use native android sdk name
buenaflor Apr 3, 2025
f6b658b
Fix analyze
buenaflor Apr 3, 2025
09c0f2b
Merge branch 'main' into feat/native-android-sdk-name
buenaflor Apr 3, 2025
e1b392f
Update Config.kt
buenaflor Apr 3, 2025
55d6535
update changelog
buenaflor Apr 3, 2025
8e78b24
update test
buenaflor Apr 4, 2025
5cc7a92
Fix test
buenaflor Apr 4, 2025
ad98dd4
Fix test
buenaflor Apr 4, 2025
ecdd8cf
Formatting
buenaflor Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Miscellaneous

- Update native android sdk name to `sentry.native.android.kmp` ([#353](https://github.com/getsentry/sentry-kotlin-multiplatform/pull/353))

### Dependencies

- Bump Cocoa SDK from v8.44.0 to v8.48.0 ([#345](https://github.com/getsentry/sentry-kotlin-multiplatform/pull/345))
Expand Down
1 change: 1 addition & 0 deletions buildSrc/src/main/java/Config.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ object Config {
val kmpCocoaSdkName = "sentry.cocoa.kmp"
val kmpJavaSdkName = "sentry.java.kmp"
val kmpAndroidSdkName = "sentry.java.android.kmp"
val kmpNativeAndroidSdkName = "sentry.native.android.kmp"
val javaPackageName = "maven:io.sentry:sentry"
val androidPackageName = "maven:io.sentry:sentry-android"
val cocoaPackageName = "cocoapods:sentry-cocoa"
Expand Down
1 change: 1 addition & 0 deletions sentry-kotlin-multiplatform/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,7 @@ buildkonfig {
buildConfigField(STRING, "SENTRY_KMP_COCOA_SDK_NAME", Config.Sentry.kmpCocoaSdkName)
buildConfigField(STRING, "SENTRY_KMP_JAVA_SDK_NAME", Config.Sentry.kmpJavaSdkName)
buildConfigField(STRING, "SENTRY_KMP_ANDROID_SDK_NAME", Config.Sentry.kmpAndroidSdkName)
buildConfigField(STRING, "SENTRY_KMP_NATIVE_ANDROID_SDK_NAME", Config.Sentry.kmpNativeAndroidSdkName)

buildConfigField(STRING, "VERSION_NAME", project.version.toString())
buildConfigField(STRING, "SENTRY_JAVA_PACKAGE_NAME", Config.Sentry.javaPackageName)
Expand Down
1 change: 1 addition & 0 deletions ...rm/src/androidMain/kotlin/io/sentry/kotlin/multiplatform/SentryPlatformOptions.android.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ internal actual fun SentryPlatformOptions.prepareForInit() {
if (sdkVersion?.packageSet?.none { it.name == BuildKonfig.SENTRY_ANDROID_PACKAGE_NAME } == true) {
sdkVersion?.addPackage(BuildKonfig.SENTRY_ANDROID_PACKAGE_NAME, BuildKonfig.SENTRY_ANDROID_VERSION)
}
nativeSdkName = BuildKonfig.SENTRY_KMP_NATIVE_ANDROID_SDK_NAME
}

internal actual fun SentryOptions.toPlatformOptionsConfiguration(): PlatformOptionsConfiguration =
Expand Down