Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Miscellaneous

- Update native android sdk name to `sentry.native.android.kmp` ([#353](https://github.com/getsentry/sentry-kotlin-multiplatform/pull/353))

### Dependencies

- Bump Cocoa SDK from v8.44.0 to v8.48.0 ([#345](https://github.com/getsentry/sentry-kotlin-multiplatform/pull/345))
Expand Down
1 change: 1 addition & 0 deletions buildSrc/src/main/java/Config.kt
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ object Config {
val kmpCocoaSdkName = "sentry.cocoa.kmp"
val kmpJavaSdkName = "sentry.java.kmp"
val kmpAndroidSdkName = "sentry.java.android.kmp"
val kmpNativeAndroidSdkName = "sentry.native.android.kmp"
val javaPackageName = "maven:io.sentry:sentry"
val androidPackageName = "maven:io.sentry:sentry-android"
val cocoaPackageName = "cocoapods:sentry-cocoa"
Expand Down
1 change: 1 addition & 0 deletions sentry-kotlin-multiplatform/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,7 @@ buildkonfig {
buildConfigField(STRING, "SENTRY_KMP_COCOA_SDK_NAME", Config.Sentry.kmpCocoaSdkName)
buildConfigField(STRING, "SENTRY_KMP_JAVA_SDK_NAME", Config.Sentry.kmpJavaSdkName)
buildConfigField(STRING, "SENTRY_KMP_ANDROID_SDK_NAME", Config.Sentry.kmpAndroidSdkName)
buildConfigField(STRING, "SENTRY_KMP_NATIVE_ANDROID_SDK_NAME", Config.Sentry.kmpNativeAndroidSdkName)

buildConfigField(STRING, "VERSION_NAME", project.version.toString())
buildConfigField(STRING, "SENTRY_JAVA_PACKAGE_NAME", Config.Sentry.javaPackageName)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ internal actual fun SentryPlatformOptions.prepareForInit() {
if (sdkVersion?.packageSet?.none { it.name == BuildKonfig.SENTRY_ANDROID_PACKAGE_NAME } == true) {
sdkVersion?.addPackage(BuildKonfig.SENTRY_ANDROID_PACKAGE_NAME, BuildKonfig.SENTRY_ANDROID_VERSION)
}
nativeSdkName = BuildKonfig.SENTRY_KMP_NATIVE_ANDROID_SDK_NAME
}

internal actual fun SentryOptions.toPlatformOptionsConfiguration(): PlatformOptionsConfiguration =
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
package io.sentry.kotlin.multiplatform

import io.sentry.kotlin.multiplatform.fakes.FakeSentryInstance
import junit.framework.TestCase.assertEquals
import kotlin.test.BeforeTest
import kotlin.test.Test

class SentryAndroidBridgeTest {
private lateinit var fixture: Fixture

@BeforeTest
fun setup() {
fixture = Fixture()
}

@Test
fun `init sets native android sdk name`() {
val sut = fixture.getSut()

sut.init { }

val option = SentryPlatformOptions().apply {
fixture.sentryInstance.lastConfiguration?.invoke(this)
}

assertEquals(BuildKonfig.SENTRY_KMP_NATIVE_ANDROID_SDK_NAME, option.nativeSdkName)
}
}

internal class Fixture {
val sentryInstance = FakeSentryInstance()

fun getSut(): SentryBridge {
return SentryBridge(sentryInstance)
}
}