Skip to content

Commit a905b7b

Browse files
authored
Merge branch 'main' into dependabot/github_actions/gradle/gradle-build-action-3.5.0
2 parents e681095 + b0fba0e commit a905b7b

File tree

11 files changed

+67
-18
lines changed

11 files changed

+67
-18
lines changed

CHANGELOG.md

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,22 @@
22

33
## Unreleased
44

5+
### Fixes
6+
7+
- Do not throw if exec operation fails ([#360](https://github.com/getsentry/sentry-kotlin-multiplatform/pull/360))
8+
9+
### Miscellaneous
10+
11+
- Update native android sdk name to `sentry.native.android.kmp` ([#353](https://github.com/getsentry/sentry-kotlin-multiplatform/pull/353))
12+
513
### Dependencies
614

7-
- Bump Cocoa SDK from v8.44.0 to v8.48.0 ([#345](https://github.com/getsentry/sentry-kotlin-multiplatform/pull/345))
8-
- [changelog](https://github.com/getsentry/sentry-cocoa/blob/main/CHANGELOG.md#8480)
9-
- [diff](https://github.com/getsentry/sentry-cocoa/compare/8.44.0...8.48.0)
10-
- Bump Java SDK from v7.18.1 to v8.6.0 ([#350](https://github.com/getsentry/sentry-kotlin-multiplatform/pull/350))
11-
- [changelog](https://github.com/getsentry/sentry-java/blob/main/CHANGELOG.md#860)
12-
- [diff](https://github.com/getsentry/sentry-java/compare/7.18.1...8.6.0)
15+
- Bump Cocoa SDK from v8.44.0 to v8.49.0 ([#345](https://github.com/getsentry/sentry-kotlin-multiplatform/pull/345), [#363](https://github.com/getsentry/sentry-kotlin-multiplatform/pull/363))
16+
- [changelog](https://github.com/getsentry/sentry-cocoa/blob/main/CHANGELOG.md#8490)
17+
- [diff](https://github.com/getsentry/sentry-cocoa/compare/8.44.0...8.49.0)
18+
- Bump Java SDK from v7.18.1 to v8.8.0 ([#350](https://github.com/getsentry/sentry-kotlin-multiplatform/pull/350), [#364](https://github.com/getsentry/sentry-kotlin-multiplatform/pull/364))
19+
- [changelog](https://github.com/getsentry/sentry-java/blob/main/CHANGELOG.md#880)
20+
- [diff](https://github.com/getsentry/sentry-java/compare/7.18.1...8.8.0)
1321

1422
## 0.11.0
1523

buildSrc/src/main/java/Config.kt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,11 @@ object Config {
3232
object Libs {
3333
val kotlinStd = "org.jetbrains.kotlin:kotlin-stdlib"
3434

35-
val sentryJavaVersion = "8.6.0"
35+
val sentryJavaVersion = "8.8.0"
3636
val sentryAndroid = "io.sentry:sentry-android:$sentryJavaVersion"
3737
val sentryJava = "io.sentry:sentry:$sentryJavaVersion"
3838

39-
val sentryCocoaVersion = "8.48.0"
39+
val sentryCocoaVersion = "8.49.0"
4040
val sentryCocoa = "Sentry"
4141

4242
object Samples {
@@ -83,6 +83,7 @@ object Config {
8383
val kmpCocoaSdkName = "sentry.cocoa.kmp"
8484
val kmpJavaSdkName = "sentry.java.kmp"
8585
val kmpAndroidSdkName = "sentry.java.android.kmp"
86+
val kmpNativeAndroidSdkName = "sentry.native.android.kmp"
8687
val javaPackageName = "maven:io.sentry:sentry"
8788
val androidPackageName = "maven:io.sentry:sentry-android"
8889
val cocoaPackageName = "cocoapods:sentry-cocoa"

sentry-kotlin-multiplatform-gradle-plugin/gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ id=io.sentry.kotlin.multiplatform.gradle
22
implementationClass=io.sentry.kotlin.multiplatform.gradle.SentryPlugin
33
versionName=0.11.0
44
group=io.sentry
5-
sentryCocoaVersion=8.48.0
5+
sentryCocoaVersion=8.49.0
66

77
# publication pom properties
88
POM_NAME=Sentry Kotlin Multiplatform Gradle Plugin

sentry-kotlin-multiplatform-gradle-plugin/src/main/java/io/sentry/kotlin/multiplatform/gradle/DerivedDataPathValueSource.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ abstract class DerivedDataPathValueSource :
4141
)
4242
it.standardOutput = buildDirOutput
4343
it.errorOutput = errOutput
44+
it.isIgnoreExitValue = true
4445
}
4546

4647
if (execOperations.exitValue == 0) {

sentry-kotlin-multiplatform-gradle-plugin/src/main/java/io/sentry/kotlin/multiplatform/gradle/ManualFrameworkPathSearchValueSource.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ abstract class ManualFrameworkPathSearchValueSource :
5050
)
5151
it.standardOutput = stdOutput
5252
it.errorOutput = errOutput
53+
it.isIgnoreExitValue = true
5354
}
5455

5556
val stringOutput = stdOutput.toString("UTF-8")

sentry-kotlin-multiplatform/build.gradle.kts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -204,6 +204,7 @@ buildkonfig {
204204
buildConfigField(STRING, "SENTRY_KMP_COCOA_SDK_NAME", Config.Sentry.kmpCocoaSdkName)
205205
buildConfigField(STRING, "SENTRY_KMP_JAVA_SDK_NAME", Config.Sentry.kmpJavaSdkName)
206206
buildConfigField(STRING, "SENTRY_KMP_ANDROID_SDK_NAME", Config.Sentry.kmpAndroidSdkName)
207+
buildConfigField(STRING, "SENTRY_KMP_NATIVE_ANDROID_SDK_NAME", Config.Sentry.kmpNativeAndroidSdkName)
207208

208209
buildConfigField(STRING, "VERSION_NAME", project.version.toString())
209210
buildConfigField(STRING, "SENTRY_JAVA_PACKAGE_NAME", Config.Sentry.javaPackageName)

sentry-kotlin-multiplatform/sentry_kotlin_multiplatform.podspec

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ Pod::Spec.new do |spec|
1212
spec.osx.deployment_target = '10.13'
1313
spec.tvos.deployment_target = '11.0'
1414
spec.watchos.deployment_target = '4.0'
15-
spec.dependency 'Sentry', '8.48.0'
15+
spec.dependency 'Sentry', '8.49.0'
1616

1717
if !Dir.exist?('build/cocoapods/framework/sentry_kotlin_multiplatform.framework') || Dir.empty?('build/cocoapods/framework/sentry_kotlin_multiplatform.framework')
1818
raise "
@@ -54,4 +54,4 @@ Pod::Spec.new do |spec|
5454
}
5555
]
5656

57-
end
57+
end

sentry-kotlin-multiplatform/src/androidMain/kotlin/io/sentry/kotlin/multiplatform/SentryPlatformOptions.android.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ internal actual fun SentryPlatformOptions.prepareForInit() {
1010
if (sdkVersion?.packageSet?.none { it.name == BuildKonfig.SENTRY_ANDROID_PACKAGE_NAME } == true) {
1111
sdkVersion?.addPackage(BuildKonfig.SENTRY_ANDROID_PACKAGE_NAME, BuildKonfig.SENTRY_ANDROID_VERSION)
1212
}
13+
nativeSdkName = BuildKonfig.SENTRY_KMP_NATIVE_ANDROID_SDK_NAME
1314
}
1415

1516
internal actual fun SentryOptions.toPlatformOptionsConfiguration(): PlatformOptionsConfiguration =
Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
package io.sentry.kotlin.multiplatform
2+
3+
import io.sentry.kotlin.multiplatform.fakes.FakeSentryInstance
4+
import junit.framework.TestCase.assertEquals
5+
import kotlin.test.BeforeTest
6+
import kotlin.test.Test
7+
8+
class SentryAndroidBridgeTest {
9+
private lateinit var fixture: Fixture
10+
11+
@BeforeTest
12+
fun setup() {
13+
fixture = Fixture()
14+
}
15+
16+
@Test
17+
fun `init sets native android sdk name`() {
18+
val sut = fixture.getSut()
19+
20+
sut.init { }
21+
22+
val option = SentryPlatformOptions().apply {
23+
fixture.sentryInstance.lastConfiguration?.invoke(this)
24+
}
25+
26+
assertEquals(BuildKonfig.SENTRY_KMP_NATIVE_ANDROID_SDK_NAME, option.nativeSdkName)
27+
}
28+
}
29+
30+
internal class Fixture {
31+
val sentryInstance = FakeSentryInstance()
32+
33+
fun getSut(): SentryBridge {
34+
return SentryBridge(sentryInstance)
35+
}
36+
}

sentry-samples/kmp-app-cocoapods/iosApp/Podfile.lock

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
PODS:
2-
- Sentry (8.48.0):
3-
- Sentry/Core (= 8.48.0)
4-
- Sentry/Core (8.48.0)
2+
- Sentry (8.49.0):
3+
- Sentry/Core (= 8.49.0)
4+
- Sentry/Core (8.49.0)
55
- shared (1.0):
6-
- Sentry (= 8.48.0)
6+
- Sentry (= 8.49.0)
77

88
DEPENDENCIES:
99
- shared (from `../shared`)
@@ -17,8 +17,8 @@ EXTERNAL SOURCES:
1717
:path: "../shared"
1818

1919
SPEC CHECKSUMS:
20-
Sentry: 1ca8405451040482877dcd344dfa3ef80b646631
21-
shared: a39a59e646f40aca21465f5b57c0ba28df8aaf8e
20+
Sentry: 5eda2559a20fa0c377b695ed9d7c178a47122891
21+
shared: 1b9a92de3fc68a6ae8f1d23b53e3a607cd5cdff7
2222

2323
PODFILE CHECKSUM: f282da88f39e69507b0a255187c8a6b644477756
2424

0 commit comments

Comments
 (0)