ref: Emit transaction instead of culprit (#458)

Author: jan-auer

bin/raven

@@ -46,7 +46,7 @@ try {
     message: 'This is a test message generated using ``raven test``',
     level: 'info',
     logger: 'sentry.test',
-    culprit: 'bin:raven at main',
+    transaction: 'bin:raven at main',
     request: {
       method: 'GET',
       url: 'http://example.com'
@@ -56,4 +56,4 @@ try {
       loadavg: os.loadavg()
     }
   });
-}
+}

lib/parsers.js

@@ -45,10 +45,12 @@ module.exports.parseError = function parseError(err, kwargs, cb) {
       kwargs.extra[name] = extraErrorProps;
     }
 
-    for (var n = frames.length - 1; n >= 0; n--) {
-      if (frames[n].in_app) {
-        kwargs.culprit = kwargs.culprit || utils.getCulprit(frames[n]);
-        break;
+    if (!kwargs.transaction && !kwargs.culprit) {
+      for (var n = frames.length - 1; n >= 0; n--) {
+        if (frames[n].in_app) {
+          kwargs.transaction = utils.getTransaction(frames[n]);
+          break;
+        }
       }
     }
 

lib/utils.js

@@ -206,7 +206,7 @@ module.exports.parseDSN = function parseDSN(dsn) {
   }
 };
 
-module.exports.getCulprit = function getCulprit(frame) {
+module.exports.getTransaction = function getTransaction(frame) {
   if (frame.module || frame.function) {
     return (frame.module || '?') + ' at ' + (frame.function || '?');
   }

test/raven.parsers.js

@@ -561,6 +561,23 @@ describe('raven.parsers', function() {
       }
     });
 
+    it('should allow specifying a custom `transaction`', function(done) {
+      try {
+        throw new Error('Foobar');
+      } catch (e) {
+        raven.parsers.parseError(
+          e,
+          {
+            transaction: 'foobar'
+          },
+          function(parsed) {
+            parsed.transaction.should.equal('foobar');
+            done();
+          }
+        );
+      }
+    });
+
     it('should have a string stack after parsing', function(done) {
       try {
         throw new Error('Derp');

test/raven.utils.js

@@ -309,30 +309,30 @@ describe('raven.utils', function() {
     });
   });
 
-  describe('#getCulprit()', function() {
+  describe('#getTransaction()', function() {
     it('should handle empty', function() {
-      raven.utils.getCulprit({}).should.eql('<unknown>');
+      raven.utils.getTransaction({}).should.eql('<unknown>');
     });
 
     it('should handle missing module', function() {
       raven.utils
-        .getCulprit({
+        .getTransaction({
           function: 'foo'
         })
         .should.eql('? at foo');
     });
 
     it('should handle missing function', function() {
       raven.utils
-        .getCulprit({
+        .getTransaction({
           module: 'foo'
         })
         .should.eql('foo at ?');
     });
 
     it('should work', function() {
       raven.utils
-        .getCulprit({
+        .getTransaction({
           module: 'foo',
           function: 'bar'
         })