feat: Override default integrations provided through array options

Author: kamilogorek

packages/core/src/sdk.ts

@@ -38,7 +38,12 @@ export function initAndBind<F extends Client, O extends Options>(
 
   let integrations = [...defaultIntegrations];
   if (Array.isArray(options.integrations)) {
-    integrations = [...integrations, ...options.integrations];
+    const providedIntegrationsNames = options.integrations.map(i => i.name);
+    integrations = [
+      // Leave only unique integrations, that were not overridden with provided integrations with the same name
+      ...integrations.filter(integration => providedIntegrationsNames.indexOf(integration.name) === -1),
+      ...options.integrations,
+    ];
   } else if (typeof options.integrations === 'function') {
     integrations = options.integrations(integrations);
   }

packages/core/test/lib/sdk.test.ts

@@ -5,7 +5,10 @@ import { TestClient } from '../mocks/client';
 declare var global: any;
 
 class MockIntegration implements Integration {
-  public name: string = 'MockIntegration';
+  public constructor(name: string) {
+    this.name = name;
+  }
+  public name: string;
   public handler: () => void = jest.fn();
   public install: () => void = () => {
     this.handler();
@@ -19,32 +22,48 @@ describe('SDK', () => {
 
   describe('initAndBind', () => {
     test('installs default integrations', () => {
-      const DEFAULT_INTEGRATIONS: Integration[] = [new MockIntegration(), new MockIntegration()];
+      const DEFAULT_INTEGRATIONS: Integration[] = [
+        new MockIntegration('MockIntegration 1'),
+        new MockIntegration('MockIntegration 2'),
+      ];
       initAndBind(TestClient, {}, DEFAULT_INTEGRATIONS);
       expect(DEFAULT_INTEGRATIONS[0].handler.mock.calls.length).toBe(1);
       expect(DEFAULT_INTEGRATIONS[1].handler.mock.calls.length).toBe(1);
     });
 
     test('installs integrations provided through options', () => {
-      const integrations: Integration[] = [new MockIntegration(), new MockIntegration()];
+      const integrations: Integration[] = [
+        new MockIntegration('MockIntegration 1'),
+        new MockIntegration('MockIntegration 2'),
+      ];
       initAndBind(TestClient, { integrations }, []);
       expect(integrations[0].handler.mock.calls.length).toBe(1);
       expect(integrations[1].handler.mock.calls.length).toBe(1);
     });
 
-    test('installs merged default integrations and one provided through options', () => {
-      const DEFAULT_INTEGRATIONS: Integration[] = [new MockIntegration(), new MockIntegration()];
-      const integrations: Integration[] = [new MockIntegration(), new MockIntegration()];
+    test('installs merged default integrations, with overrides provided through options', () => {
+      const DEFAULT_INTEGRATIONS: Integration[] = [
+        new MockIntegration('MockIntegration 1'),
+        new MockIntegration('MockIntegration 2'),
+      ];
+      const integrations: Integration[] = [
+        new MockIntegration('MockIntegration 1'),
+        new MockIntegration('MockIntegration 3'),
+      ];
       initAndBind(TestClient, { integrations }, DEFAULT_INTEGRATIONS);
-      expect(DEFAULT_INTEGRATIONS[0].handler.mock.calls.length).toBe(1);
+      // 'MockIntegration 1' should be overridden by the one with the same name provided through options
+      expect(DEFAULT_INTEGRATIONS[0].handler.mock.calls.length).toBe(0);
       expect(DEFAULT_INTEGRATIONS[1].handler.mock.calls.length).toBe(1);
       expect(integrations[0].handler.mock.calls.length).toBe(1);
       expect(integrations[1].handler.mock.calls.length).toBe(1);
     });
 
     test('installs integrations returned from a callback function', () => {
-      const DEFAULT_INTEGRATIONS: Integration[] = [new MockIntegration(), new MockIntegration()];
-      const newIntegration = new MockIntegration();
+      const DEFAULT_INTEGRATIONS: Integration[] = [
+        new MockIntegration('MockIntegration 1'),
+        new MockIntegration('MockIntegration 2'),
+      ];
+      const newIntegration = new MockIntegration('MockIntegration 3');
       initAndBind(
         TestClient,
         {