test: [browser/LinkedErrors] Improve test code to be more realistic (#1694)

* browser/LinkedErrors/test: Use `BrowserBackend` to generate `event`

The current implementation was missing the original exception in the `result.exception.values` array, which lead to the tests asserting on unrealistic results. This commit changes the test code to use the `BrowserBackend` class to generate the `event` from the actual exception.

* browser/LinkedErrors/test: Rearrange errors to visualize creation order

`one` depends on `two` depends on `three`

Author: Turbo87

packages/browser/test/integrations/linkederrors.test.ts

@@ -1,5 +1,6 @@
 import { expect } from 'chai';
 import { stub } from 'sinon';
+import { BrowserBackend } from '../../src/backend';
 import { LinkedErrors } from '../../src/integrations/linkederrors';
 
 let linkedErrors: LinkedErrors;
@@ -52,67 +53,66 @@ describe('LinkedErrors', () => {
       expect(spy.calledOnce).equal(true);
     });
 
-    it('should recursively walk error to find linked exceptions and assign them to the event', () => {
-      const event = {
-        exception: {
-          values: [],
-        },
-        message: 'foo',
-      };
+    it('should recursively walk error to find linked exceptions and assign them to the event', async () => {
+      const three: ExtendedError = new SyntaxError('three');
 
-      const one: ExtendedError = new Error('one');
       const two: ExtendedError = new TypeError('two');
-      const three: ExtendedError = new SyntaxError('three');
+      two.cause = three;
 
-      const originalException = one;
+      const one: ExtendedError = new Error('one');
       one.cause = two;
-      two.cause = three;
 
+      const originalException = one;
+      const backend = new BrowserBackend({});
+      const event = await backend.eventFromException(originalException);
       const result = linkedErrors.handler(event, {
         originalException,
       });
 
       // It shouldn't include root exception, as it's already processed in the event by the main error handler
-      expect(result!.exception!.values!.length).equal(2);
-      expect(result!.exception!.values![0].type).equal('TypeError');
-      expect(result!.exception!.values![0].value).equal('two');
+      expect(result!.exception!.values!.length).equal(3);
+      expect(result!.exception!.values![0].type).equal('Error');
+      expect(result!.exception!.values![0].value).equal('one');
       expect(result!.exception!.values![0].stacktrace).to.have.property('frames');
-      expect(result!.exception!.values![1].type).equal('SyntaxError');
-      expect(result!.exception!.values![1].value).equal('three');
+      expect(result!.exception!.values![1].type).equal('TypeError');
+      expect(result!.exception!.values![1].value).equal('two');
       expect(result!.exception!.values![1].stacktrace).to.have.property('frames');
+      expect(result!.exception!.values![2].type).equal('SyntaxError');
+      expect(result!.exception!.values![2].value).equal('three');
+      expect(result!.exception!.values![2].stacktrace).to.have.property('frames');
     });
 
-    it('should allow to change walk key', () => {
+    it('should allow to change walk key', async () => {
       linkedErrors = new LinkedErrors({
         key: 'reason',
       });
-      const event = {
-        exception: {
-          values: [],
-        },
-        message: 'foo',
-      };
 
-      const one: ExtendedError = new Error('one');
-      const two: ExtendedError = new TypeError('two');
       const three: ExtendedError = new SyntaxError('three');
 
-      const originalException = one;
-      one.reason = two;
+      const two: ExtendedError = new TypeError('two');
       two.reason = three;
 
+      const one: ExtendedError = new Error('one');
+      one.reason = two;
+
+      const originalException = one;
+      const backend = new BrowserBackend({});
+      const event = await backend.eventFromException(originalException);
       const result = linkedErrors.handler(event, {
         originalException,
       });
 
       // It shouldn't include root exception, as it's already processed in the event by the main error handler
-      expect(result!.exception!.values!.length).equal(2);
-      expect(result!.exception!.values![0].type).equal('TypeError');
-      expect(result!.exception!.values![0].value).equal('two');
+      expect(result!.exception!.values!.length).equal(3);
+      expect(result!.exception!.values![0].type).equal('Error');
+      expect(result!.exception!.values![0].value).equal('one');
       expect(result!.exception!.values![0].stacktrace).to.have.property('frames');
-      expect(result!.exception!.values![1].type).equal('SyntaxError');
-      expect(result!.exception!.values![1].value).equal('three');
+      expect(result!.exception!.values![1].type).equal('TypeError');
+      expect(result!.exception!.values![1].value).equal('two');
       expect(result!.exception!.values![1].stacktrace).to.have.property('frames');
+      expect(result!.exception!.values![2].type).equal('SyntaxError');
+      expect(result!.exception!.values![2].value).equal('three');
+      expect(result!.exception!.values![2].stacktrace).to.have.property('frames');
     });
   });
 });