Fix tests, lint errors

Author: benvinegar

plugins/angular.js

@@ -10,7 +10,9 @@ var angularPattern = /^\[((?:[$a-zA-Z0-9]+:)?(?:[$a-zA-Z0-9]+))\] (.+?)\n(\S+)$/
 
 function angularPlugin(Raven, angular) {
     /*jshint validthis:true*/
-    var angular = angular || window.angular;
+    angular = angular || window.angular;
+
+    if (!angular) return;
 
     function RavenProvider() {
         this.$get = ['$window', function($window) {
@@ -32,9 +34,6 @@ function angularPlugin(Raven, angular) {
         };
     }
 
-    var angular = window.angular;
-    if (!angular) return;
-
     angular.module('ngRaven', [])
         .provider('Raven',  RavenProvider)
         .config(['$provide', ExceptionHandlerProvider]);

plugins/backbone.js

@@ -3,9 +3,10 @@
  *
  * Patches Backbone.Events callbacks.
  */
+'use strict';
 
 function backbonePlugin(Raven, Backbone) {
-  var Backbone = Backbone || window.Backbone;
+  Backbone = Backbone || window.Backbone;
 
   // quit if Backbone isn't on the page
   if (!Backbone) return;

plugins/console.js

@@ -7,7 +7,7 @@
 'use strict';
 
 function consolePlugin(Raven, console) {
-    var console = console || window.console || {};
+    console = console || window.console || {};
 
     var originalConsole = console,
         logLevels = ['debug', 'info', 'warn', 'error'],

plugins/native.js

@@ -4,6 +4,8 @@
  * Extends support for global error handling for asynchronous browser
  * functions. Adopted from Closure Library's errorhandler.js.
  */
+'use strict';
+
 function nativePlugin(Raven) {
     var _helper = function _helper(fnName) {
         var originalFn = window[fnName];

plugins/require.js

@@ -1,3 +1,4 @@
+/*global define*/
 /**
  * require.js plugin
  *
@@ -6,10 +7,10 @@
 'use strict';
 
 function requirePlugin(Raven) {
-	if (typeof define === 'function' && define.amd) {
-	    window.define = Raven.wrap({deep: false}, define);
-	    window.require = Raven.wrap({deep: false}, require);
-	}
+    if (typeof define === 'function' && define.amd) {
+        window.define = Raven.wrap({deep: false}, define);
+        window.require = Raven.wrap({deep: false}, require);
+    }
 }
 
 module.exports = requirePlugin;

test/raven.test.js

@@ -1580,9 +1580,15 @@ describe('Raven (public API)', function() {
         it('should register itself with TraceKit', function() {
             this.sinon.stub(Raven, 'isSetup').returns(true);
             this.sinon.stub(TraceKit.report, 'subscribe');
+            this.sinon.stub(Raven, '_handleStackInfo');
             assert.equal(Raven, Raven.install());
             assert.isTrue(TraceKit.report.subscribe.calledOnce);
-            assert.equal(TraceKit.report.subscribe.lastCall.args[0], Raven._handleStackInfo);
+
+            // `install` subscribes to TraceKit w/ an anonymous function that
+            // wraps _handleStackInfo to preserve `this`. Invoke the anonymous
+            // function and verify that `_handleStackInfo` is called.
+            TraceKit.report.subscribe.lastCall.args[0]();
+            assert.isTrue(Raven._handleStackInfo.calledOnce);
         });
 
         it('should not register itself more than once', function() {