fix(nextjs): Gracefully handle undefined beforeFiles in rewrites (#7649)

bertho-zero · Luca Forstner · web-flow · commit ca704ef7f605 · 2023-03-29T16:14:43.000+02:00
Co-authored-by: Luca Forstner &lt;luca.forstner@sentry.io&gt;
diff --git a/packages/nextjs/src/config/types.ts b/packages/nextjs/src/config/types.ts
@@ -53,9 +53,9 @@ export type NextConfigObject = {
   rewrites?: () => Promise<
     | NextRewrite[]
     | {
-        beforeFiles: NextRewrite[];
-        afterFiles: NextRewrite[];
-        fallback: NextRewrite[];
+        beforeFiles?: NextRewrite[];
+        afterFiles?: NextRewrite[];
+        fallback?: NextRewrite[];
       }
   >;
 };
diff --git a/packages/nextjs/src/config/withSentryConfig.ts b/packages/nextjs/src/config/withSentryConfig.ts
@@ -104,7 +104,7 @@ function setUpTunnelRewriteRules(userNextConfig: NextConfigObject, tunnelPath: s
     } else {
       return {
         ...originalRewritesResult,
-        beforeFiles: [injectedRewrite, ...originalRewritesResult.beforeFiles],
+        beforeFiles: [injectedRewrite, ...(originalRewritesResult.beforeFiles || [])],
       };
     }
   };

Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ function setUpTunnelRewriteRules(userNextConfig: NextConfigObject, tunnelPath: s`
`104`	`104`	`} else {`
`105`	`105`	`return {`
`106`	`106`	`...originalRewritesResult,`
`107`		`- beforeFiles: [injectedRewrite, ...originalRewritesResult.beforeFiles],`
	`107`	`+ beforeFiles: [injectedRewrite, ...(originalRewritesResult.beforeFiles \|\| [])],`
`108`	`108`	`};`
`109`	`109`	`}`
`110`	`110`	`};`