fix: check for undefined stacks in isSameStacktrace

Author: Matt Sprague

packages/raven-js/src/utils.js

@@ -3,7 +3,11 @@ var stringify = require('../vendor/json-stringify-safe/stringify');
 var _window =
   typeof window !== 'undefined'
     ? window
-    : typeof global !== 'undefined' ? global : typeof self !== 'undefined' ? self : {};
+    : typeof global !== 'undefined'
+      ? global
+      : typeof self !== 'undefined'
+        ? self
+        : {};
 
 function isObject(what) {
   return typeof what === 'object' && what !== null;
@@ -417,6 +421,9 @@ function isSameStacktrace(stack1, stack2) {
   var frames1 = stack1.frames;
   var frames2 = stack2.frames;
 
+  // Exit early if stacktrace is malformed
+  if (frames1 === undefined || frames2 === undefined) return false;
+
   // Exit early if frame count differs
   if (frames1.length !== frames2.length) return false;
 

packages/raven-js/test/utils.test.js

@@ -25,6 +25,7 @@ var truncate = utils.truncate;
 var urlencode = utils.urlencode;
 var htmlTreeAsString = utils.htmlTreeAsString;
 var htmlElementAsString = utils.htmlElementAsString;
+var isSameStacktrace = utils.isSameStacktrace;
 var parseUrl = utils.parseUrl;
 var safeJoin = utils.safeJoin;
 var serializeException = utils.serializeException;
@@ -357,6 +358,17 @@ describe('utils', function() {
     });
   });
 
+  describe('isSameStacktrace', function() {
+    it('does not fail if frames are not present', function() {
+      var validStack = {frames: []};
+      var invalidStack = {};
+      var invalidResult = isSameStacktrace(validStack, invalidStack);
+      assert.equal(invalidResult, false);
+      invalidResult = isSameStacktrace(invalidStack, validStack);
+      assert.equal(invalidResult, false);
+    });
+  });
+
   describe('parseUrl', function() {
     it('should parse fully qualified URLs', function() {
       assert.deepEqual(parseUrl('http://example.com/foo'), {