chore: properly replace the smallest preset value

Author: logaretm

dev-packages/rollup-utils/bundleHelpers.mjs

@@ -15,7 +15,7 @@ import {
   makeBannerOptions,
   makeTerserPlugin,
 } from './plugins/index.mjs';
-import { mergePlugins } from './utils.mjs';
+import { mergePlugins, treeShakePreset } from './utils.mjs';
 
 const BUNDLE_VARIANTS = ['.js', '.min.js', '.debug.min.js'];
 
@@ -109,7 +109,7 @@ export function makeBaseBundleConfig(options) {
       strict: false,
       esModule: false,
     },
-    treeshake: 'smallest',
+    treeshake: treeShakePreset('smallest'),
   };
 
   const bundleTypeConfigMap = {

dev-packages/rollup-utils/index.mjs

@@ -1,4 +1,4 @@
 export * from './plugins/index.mjs';
 export * from './bundleHelpers.mjs';
 export * from './npmHelpers.mjs';
-export { insertAt } from './utils.mjs';
+export { insertAt, treeShakePreset } from './utils.mjs';

dev-packages/rollup-utils/utils.mjs

@@ -39,3 +39,22 @@ export function mergePlugins(pluginsA, pluginsB) {
 
   return plugins;
 }
+
+/**
+ * Creates a treeshake setting preset, rolldown doesn't have "smallest" as a preset, so we need to create our own.
+ * Smallest
+ * https://rolldown.rs/options/treeshake#treeshake
+ * https://rollupjs.org/configuration-options/#treeshake
+ * @param {boolean | readonly string[] | ModuleSideEffectsRule[] | ((id: string, external: boolean) => boolean | undefined) | 'no-external' | 'smallest'} preset - The preset to use
+ */
+export function treeShakePreset(preset) {
+  if (preset === 'smallest') {
+    return {
+      propertyReadSideEffects: false,
+      moduleSideEffects: false,
+      unknownGlobalSideEffects: false,
+    };
+  }
+
+  return preset;
+}

packages/replay-worker/rollup.examples.config.mjs

@@ -1,3 +1,4 @@
+import { treeShakePreset } from '@sentry-internal/rollup-utils';
 import { defineConfig } from 'rolldown';
 
 const config = defineConfig([
@@ -8,7 +9,7 @@ const config = defineConfig([
       file: './examples/worker.js',
       format: 'esm',
     },
-    treeshake: 'smallest',
+    treeshake: treeShakePreset('smallest'),
   },
   {
     input: ['./src/_worker.ts'],
@@ -17,7 +18,7 @@ const config = defineConfig([
       file: './examples/worker.min.js',
       format: 'esm',
     },
-    treeshake: 'smallest',
+    treeshake: treeShakePreset('smallest'),
   },
 ]);
 

packages/replay-worker/rollup.worker.config.mjs

@@ -1,11 +1,12 @@
 // inspired by https://justinribeiro.com/chronicle/2020/07/17/building-module-web-workers-for-cross-browser-compatibility-with-rollup/
 
+import { treeShakePreset } from '@sentry-internal/rollup-utils';
 import { defineConfig } from 'rolldown';
 
 const config = defineConfig([
   {
     input: ['./src/index.ts'],
-    treeshake: 'smallest',
+    treeshake: treeShakePreset('smallest'),
     tsconfig: './tsconfig.build.json',
     output: {
       dir: './build/esm',
@@ -22,7 +23,7 @@ const config = defineConfig([
       format: 'esm',
       minify: true,
     },
-    treeshake: 'smallest',
+    treeshake: treeShakePreset('smallest'),
     plugins: [
       {
         name: 'worker-to-string',
@@ -40,7 +41,7 @@ const config = defineConfig([
       format: 'esm',
       minify: true,
     },
-    treeshake: 'smallest',
+    treeshake: treeShakePreset('smallest'),
   },
 ]);