Better integration test assertions (assert stack depth > 1)

Author: benvinegar

test/integration/test.js

@@ -24,52 +24,9 @@ function createIframe(done) {
 }
 
 describe('integration', function () {
-    var timeoutStackDepth = 0;
-    var eventHandlerStackDepth = 0;
-
-    before(function (done) {
-        // Before running any tests, throw/catch a known error
-        // inside setTimeout to get a baseline expected stack
-        // depth for future errors (this is different in every
-        // browser).
-        var iframe = createIframe(function () {
-            iframe.contentWindow.setTimeout(function () {
-                try {
-                    iframe.contentWindow.foo();
-                } catch (e) {
-                    var trace = Raven.TraceKit.computeStackTrace(e);
-                    timeoutStackDepth = trace.stack.length;
-                }
-
-                var doc = iframe.contentWindow.document;
-                var div = doc.createElement('div');
-                doc.body.appendChild(div);
-                div.addEventListener('click', function () {
-                    try {
-                        foo();
-                    } catch (e) {
-                        var trace = Raven.TraceKit.computeStackTrace(e);
-                        eventHandlerStackDepth = trace.stack.length;
-                    }
-                }, false);
-
-                var evt;
-                if (doc.createEvent) {
-                    evt = doc.createEvent('MouseEvents');
-                    evt.initEvent('click', true, false);
-                    div.dispatchEvent(evt);
-                } else if(doc.createEventObject) {
-                    div.fireEvent('onclick');
-                }
-
-                document.body.removeChild(iframe);
-                done();
-            });
-        });
-    });
 
     beforeEach(function (done) {
-        var iframe = this.iframe = createIframe(done);
+        this.iframe = createIframe(done);
     });
 
     afterEach(function () {
@@ -136,7 +93,7 @@ describe('integration', function () {
                 },
                 function () {
                     var ravenData = iframe.contentWindow.ravenData;
-                    assert.equal(ravenData.exception.values[0].stacktrace.frames.length, eventHandlerStackDepth + 1);
+                    assert.isAbove(ravenData.exception.values[0].stacktrace.frames.length, 2);
                 }
             );
         });
@@ -182,7 +139,7 @@ describe('integration', function () {
                 },
                 function () {
                     var ravenData = iframe.contentWindow.ravenData;
-                    assert.equal(ravenData.exception.values[0].stacktrace.frames.length, timeoutStackDepth);
+                    assert.isAbove(ravenData.exception.values[0].stacktrace.frames.length, 2);
                 }
             );
         });
@@ -200,7 +157,7 @@ describe('integration', function () {
                 },
                 function () {
                     var ravenData = iframe.contentWindow.ravenData;
-                    assert.equal(ravenData.exception.values[0].stacktrace.frames.length, timeoutStackDepth);
+                    assert.isAbove(ravenData.exception.values[0].stacktrace.frames.length, 2);
                 }
             );
         });
@@ -219,7 +176,7 @@ describe('integration', function () {
                 },
                 function () {
                     var ravenData = iframe.contentWindow.ravenData;
-                    assert.equal(ravenData.exception.values[0].stacktrace.frames.length, timeoutStackDepth);
+                    assert.isAbove(ravenData.exception.values[0].stacktrace.frames.length, 2);
                 }
             );
         });
@@ -241,7 +198,7 @@ describe('integration', function () {
                   var ravenData = iframe.contentWindow.ravenData;
                   console.log(ravenData);
                   // # of frames alter significantly between chrome/firefox & safari
-                  assert.isTrue(ravenData.exception.values[0].stacktrace.frames.length >= 4);
+                  assert.isAbove(ravenData.exception.values[0].stacktrace.frames.length, 2);
               }
             );
         });