test: Skip double installing playwright in E2E tests (#14633)

We do install this on CI separately before, so this should not be
necessary (esp. we do not need firefox, as we only run these tests on
chromium).

This should shave off about 20s of the `build` step for all the E2E
tests!

Author: mydea

.github/actions/install-playwright/action.yml

@@ -4,6 +4,9 @@ inputs:
   browsers:
     description: 'What browsers to install.'
     default: 'chromium webkit firefox'
+  cwd:
+    description: 'The working directory to run Playwright in.'
+    default: '.'
 
 runs:
   using: "composite"
@@ -12,6 +15,8 @@ runs:
         id: playwright-version
         run: echo "version=$(node -p "require('@playwright/test/package.json').version")" >> $GITHUB_OUTPUT
         shell: bash
+        working-directory: ${{ inputs.cwd }}
+
 
       - name: Restore cached playwright binaries
         uses: actions/cache/restore@v4
@@ -26,11 +31,13 @@ runs:
         run: npx playwright install chromium webkit firefox --with-deps
         if: steps.playwright-cache.outputs.cache-hit != 'true'
         shell: bash
+        working-directory: ${{ inputs.cwd }}
 
       - name: Install Playwright system dependencies only (cached)
         run: npx playwright install-deps ${{ inputs.browsers || 'chromium webkit firefox' }}
         if: steps.playwright-cache.outputs.cache-hit == 'true'
         shell: bash
+        working-directory: ${{ inputs.cwd }}
 
       # Only store cache on develop branch
       - name: Store cached playwright binaries

.github/workflows/build.yml

@@ -920,11 +920,6 @@ jobs:
         if: steps.restore-tarball-cache.outputs.cache-hit != 'true'
         run: yarn build:tarball
 
-      - name: Install Playwright
-        uses: ./.github/actions/install-playwright
-        with:
-          browsers: chromium
-
       - name: Get node version
         id: versions
         run: |
@@ -945,6 +940,12 @@ jobs:
         timeout-minutes: 7
         run: pnpm ${{ matrix.build-command || 'test:build' }}
 
+      - name: Install Playwright
+        uses: ./.github/actions/install-playwright
+        with:
+          browsers: chromium
+          cwd: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}
+
       - name: Run E2E test
         working-directory: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}
         timeout-minutes: 10
@@ -984,7 +985,7 @@ jobs:
 
   # - We skip optional tests on release branches
   job_optional_e2e_tests:
-    name: E2E ${{ matrix.label || matrix.test-application }} Test
+    name: E2E ${{ matrix.label || matrix.test-application }} Test (optional)
     # We only run E2E tests for non-fork PRs because the E2E tests require secrets to work and they can't be accessed from forks
     # We need to add the `always()` check here because the previous step has this as well :(
     # See: https://github.com/actions/runner/issues/2205
@@ -1039,11 +1040,6 @@ jobs:
         if: steps.restore-tarball-cache.outputs.cache-hit != 'true'
         run: yarn build:tarball
 
-      - name: Install Playwright
-        uses: ./.github/actions/install-playwright
-        with:
-          browsers: chromium
-
       - name: Get node version
         id: versions
         run: |
@@ -1064,6 +1060,12 @@ jobs:
         timeout-minutes: 7
         run: pnpm ${{ matrix.build-command || 'test:build' }}
 
+      - name: Install Playwright
+        uses: ./.github/actions/install-playwright
+        with:
+          browsers: chromium
+          cwd: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}
+
       - name: Run E2E test
         working-directory: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}
         timeout-minutes: 10

dev-packages/e2e-tests/test-applications/angular-17/package.json

@@ -9,7 +9,7 @@
     "build": "ng build",
     "watch": "ng build --watch --configuration development",
     "test": "playwright test",
-    "test:build": "pnpm install && npx playwright install && pnpm build",
+    "test:build": "pnpm install && pnpm build",
     "test:assert": "playwright test",
     "clean": "npx rimraf .angular node_modules pnpm-lock.yaml dist"
   },

dev-packages/e2e-tests/test-applications/angular-18/package.json

@@ -9,7 +9,7 @@
     "build": "ng build",
     "watch": "ng build --watch --configuration development",
     "test": "playwright test",
-    "test:build": "pnpm install && npx playwright install && pnpm build",
+    "test:build": "pnpm install && pnpm build",
     "test:assert": "playwright test",
     "clean": "npx rimraf .angular node_modules pnpm-lock.yaml dist"
   },

dev-packages/e2e-tests/test-applications/angular-19/package.json

@@ -9,7 +9,7 @@
     "build": "ng build",
     "watch": "ng build --watch --configuration development",
     "test": "playwright test",
-    "test:build": "pnpm install && npx playwright install && pnpm build",
+    "test:build": "pnpm install && pnpm build",
     "test:assert": "playwright test",
     "clean": "npx rimraf .angular node_modules pnpm-lock.yaml dist"
   },

dev-packages/e2e-tests/test-applications/astro-4/package.json

@@ -8,7 +8,7 @@
     "build": "astro check && astro build",
     "preview": "astro preview",
     "astro": "astro",
-    "test:build": "pnpm install && npx playwright install && pnpm build",
+    "test:build": "pnpm install && pnpm build",
     "test:assert": "TEST_ENV=production playwright test"
   },
   "dependencies": {

dev-packages/e2e-tests/test-applications/astro-5/package.json

@@ -7,7 +7,7 @@
     "build": "astro build",
     "preview": "astro preview",
     "astro": "astro",
-    "test:build": "pnpm install && npx playwright install && pnpm build",
+    "test:build": "pnpm install && pnpm build",
     "test:assert": "TEST_ENV=production playwright test"
   },
   "dependencies": {

dev-packages/e2e-tests/test-applications/create-next-app/package.json

@@ -7,8 +7,8 @@
     "clean": "npx rimraf node_modules pnpm-lock.yaml .next",
     "test:prod": "TEST_ENV=prod playwright test",
     "test:dev": "TEST_ENV=dev playwright test",
-    "test:build": "pnpm install && npx playwright install && pnpm build",
-    "test:build-13": "pnpm install && pnpm add next@13.4.19 && npx playwright install && pnpm build",
+    "test:build": "pnpm install && pnpm build",
+    "test:build-13": "pnpm install && pnpm add next@13.4.19 && pnpm build",
     "test:assert": "pnpm test:prod && pnpm test:dev"
   },
   "dependencies": {

dev-packages/e2e-tests/test-applications/create-remix-app-express-legacy/package.json

@@ -9,7 +9,7 @@
     "start": "cross-env NODE_ENV=production node ./server.mjs",
     "typecheck": "tsc",
     "clean": "npx rimraf node_modules pnpm-lock.yaml",
-    "test:build": "pnpm install && npx playwright install && pnpm build",
+    "test:build": "pnpm install && pnpm build",
     "test:assert": "pnpm playwright test"
   },
   "dependencies": {

dev-packages/e2e-tests/test-applications/create-remix-app-express-vite-dev/package.json

@@ -8,7 +8,7 @@
     "start": "cross-env NODE_ENV=production node ./server.mjs",
     "typecheck": "tsc",
     "clean": "npx rimraf node_modules pnpm-lock.yaml",
-    "test:build": "pnpm install && npx playwright install && pnpm build",
+    "test:build": "pnpm install && pnpm build",
     "test:assert": "pnpm playwright test"
   },
   "dependencies": {