ref: The smallest possible interface for our needs - PromiseLike

Author: kamilogorek

packages/browser/src/backend.ts

@@ -56,7 +56,7 @@ export class BrowserBackend extends BaseBackend<BrowserOptions> {
   /**
    * @inheritDoc
    */
-  public eventFromException(exception: any, hint?: EventHint): Promise<Event> {
+  public eventFromException(exception: any, hint?: EventHint): PromiseLike<Event> {
     const syntheticException = (hint && hint.syntheticException) || undefined;
     const event = eventFromUnknownInput(exception, syntheticException, {
       attachStacktrace: this._options.attachStacktrace,
@@ -74,7 +74,7 @@ export class BrowserBackend extends BaseBackend<BrowserOptions> {
   /**
    * @inheritDoc
    */
-  public eventFromMessage(message: string, level: Severity = Severity.Info, hint?: EventHint): Promise<Event> {
+  public eventFromMessage(message: string, level: Severity = Severity.Info, hint?: EventHint): PromiseLike<Event> {
     const syntheticException = (hint && hint.syntheticException) || undefined;
     const event = eventFromString(message, syntheticException, {
       attachStacktrace: this._options.attachStacktrace,

packages/browser/src/client.ts

@@ -51,7 +51,7 @@ export class BrowserClient extends BaseClient<BrowserBackend, BrowserOptions> {
   /**
    * @inheritDoc
    */
-  protected _prepareEvent(event: Event, scope?: Scope, hint?: EventHint): Promise<Event | null> {
+  protected _prepareEvent(event: Event, scope?: Scope, hint?: EventHint): PromiseLike<Event | null> {
     event.platform = event.platform || 'javascript';
     event.sdk = {
       ...event.sdk,

packages/browser/src/integrations/breadcrumbs.ts

@@ -276,7 +276,7 @@ export class Breadcrumbs implements Integration {
             );
             return response;
           })
-          .catch((error: Error) => {
+          .then(null, (error: Error) => {
             Breadcrumbs.addBreadcrumb(
               {
                 category: 'fetch',

packages/browser/src/sdk.ts

@@ -133,7 +133,7 @@ export function onLoad(callback: () => void): void {
  *
  * @param timeout Maximum time in ms the client should wait.
  */
-export function flush(timeout?: number): Promise<boolean> {
+export function flush(timeout?: number): PromiseLike<boolean> {
   const client = getCurrentHub().getClient<BrowserClient>();
   if (client) {
     return client.flush(timeout);
@@ -147,7 +147,7 @@ export function flush(timeout?: number): Promise<boolean> {
  *
  * @param timeout Maximum time in ms the client should wait.
  */
-export function close(timeout?: number): Promise<boolean> {
+export function close(timeout?: number): PromiseLike<boolean> {
   const client = getCurrentHub().getClient<BrowserClient>();
   if (client) {
     return client.close(timeout);

packages/browser/src/transports/base.ts

@@ -19,14 +19,14 @@ export abstract class BaseTransport implements Transport {
   /**
    * @inheritDoc
    */
-  public sendEvent(_: Event): Promise<Response> {
+  public sendEvent(_: Event): PromiseLike<Response> {
     throw new SentryError('Transport Class has to implement `sendEvent` method');
   }
 
   /**
    * @inheritDoc
    */
-  public close(timeout?: number): Promise<boolean> {
+  public close(timeout?: number): PromiseLike<boolean> {
     return this._buffer.drain(timeout);
   }
 }

packages/browser/src/transports/fetch.ts

@@ -10,7 +10,7 @@ export class FetchTransport extends BaseTransport {
   /**
    * @inheritDoc
    */
-  public sendEvent(event: Event): Promise<Response> {
+  public sendEvent(event: Event): PromiseLike<Response> {
     const defaultOptions: RequestInit = {
       body: JSON.stringify(event),
       method: 'POST',

packages/browser/src/transports/xhr.ts

@@ -8,7 +8,7 @@ export class XHRTransport extends BaseTransport {
   /**
    * @inheritDoc
    */
-  public sendEvent(event: Event): Promise<Response> {
+  public sendEvent(event: Event): PromiseLike<Response> {
     return this._buffer.add(
       new SyncPromise<Response>((resolve, reject) => {
         const request = new XMLHttpRequest();

packages/browser/test/unit/mocks/simpletransport.ts

@@ -4,7 +4,7 @@ import { Event, Response, Status } from '../../../src';
 import { BaseTransport } from '../../../src/transports';
 
 export class SimpleTransport extends BaseTransport {
-  public sendEvent(_: Event): Promise<Response> {
+  public sendEvent(_: Event): PromiseLike<Response> {
     return this._buffer.add(
       SyncPromise.resolve({
         status: Status.fromHttpCode(200),

packages/browser/test/unit/transports/fetch.test.ts

@@ -55,7 +55,7 @@ describe('FetchTransport', () => {
 
       fetch.returns(Promise.reject(response));
 
-      return transport.sendEvent(payload).catch(res => {
+      return transport.sendEvent(payload).then(null, res => {
         expect(res.status).equal(403);
         expect(fetch.calledOnce).equal(true);
         expect(

packages/browser/test/unit/transports/xhr.test.ts

@@ -47,7 +47,7 @@ describe('XHRTransport', () => {
     it('rejects with non-200 status code', done => {
       server.respondWith('POST', transportUrl, [403, {}, '']);
 
-      transport.sendEvent(payload).catch(res => {
+      transport.sendEvent(payload).then(null, res => {
         expect(res.status).equal(403);
 
         const request = server.requests[0];