Move jQuery onready handler into raven core; delete jquery plugin

benvinegar · benvinegar · commit 8f6ba80f2c38 · 2015-12-17T15:23:07.000-08:00
diff --git a/docs/config.rst b/docs/config.rst
@@ -230,7 +230,7 @@ Putting it all together
     <body>
         ...
         <script src="jquery.min.js"></script>
-        <script src="https://cdn.ravenjs.com/2.0.0/jquery/raven.min.js"></script>
+        <script src="https://cdn.ravenjs.com/2.0.0/raven.min.js"></script>
         <script>
             Raven.config('___PUBLIC_DSN___', {
                 logger: 'my-logger',
diff --git a/docs/index.rst b/docs/index.rst
@@ -26,7 +26,7 @@ scripts.  For all details see :doc:`install`.
 
 .. sourcecode:: html
 
-    <script src="https://cdn.ravenjs.com/2.0.0/jquery/raven.min.js"></script>
+    <script src="https://cdn.ravenjs.com/2.0.0/raven.min.js"></script>
 
 Configuring the Project
 -----------------------
diff --git a/docs/install.rst b/docs/install.rst
@@ -9,13 +9,13 @@ So for example:
 .. sourcecode:: html
 
     <script src="jquery.js"></script>
-    <script src="https://cdn.ravenjs.com/2.0.0/jquery/raven.min.js"></script>
+    <script src="https://cdn.ravenjs.com/2.0.0/raven.min.js"></script>
     <script>Raven.config('___PUBLIC_DSN___').install();</script>
     <script src="app.js"></script>
 
 This allows the ability for Raven's integrations to instrument themselves. If
 included before something like jQuery, it'd be impossible to use for
-example, the jquery plugin.
+example, the jQuery plugin.
 
 Using our CDN
 ~~~~~~~~~~~~~
@@ -28,7 +28,7 @@ Our CDN distributes builds with and without :doc:`integrations <integrations/ind
 
 .. sourcecode:: html
 
-    <script src="https://cdn.ravenjs.com/2.0.0/jquery/raven.min.js"></script>
+    <script src="https://cdn.ravenjs.com/2.0.0/raven.min.js"></script>
 
 **We highly recommend trying out a plugin or two since it'll greatly
 improve the chances that we can collect good information.**
diff --git a/docs/integrations/backbone.rst b/docs/integrations/backbone.rst
@@ -9,7 +9,7 @@ after you load all other external libraries (like jQuery), but before your code.
 
 .. sourcecode:: html
 
-    <script src="https://cdn.ravenjs.com/1.3.0/backbone,jquery/raven.min.js"></script>
+    <script src="https://cdn.ravenjs.com/1.3.0/backbone/raven.min.js"></script>
 
 Configuring the Client
 ----------------------
diff --git a/docs/integrations/ember.rst b/docs/integrations/ember.rst
@@ -9,7 +9,7 @@ after you load all other external libraries (like jQuery), but before your code.
 
 .. sourcecode:: html
 
-    <script src="https://cdn.ravenjs.com/1.3.0/ember,jquery/raven.min.js"></script>
+    <script src="https://cdn.ravenjs.com/1.3.0/ember/raven.min.js"></script>
 
 Configuring the Client
 ----------------------
diff --git a/docs/integrations/react.rst b/docs/integrations/react.rst
@@ -9,7 +9,7 @@ after you load all other external libraries (like jQuery), but before your code.
 
 .. sourcecode:: html
 
-    <script src="https://cdn.ravenjs.com/1.3.0/jquery/raven.min.js"></script>
+    <script src="https://cdn.ravenjs.com/1.3.0/raven.min.js"></script>
 
 Configuring the Client
 ----------------------
diff --git a/package.json b/package.json
@@ -28,7 +28,6 @@
     "grunt-release": "~0.6.0",
     "grunt-s3": "~0.2.0-alpha.3",
     "grunt-sri": "mattrobenolt/grunt-sri#pretty",
-    "jquery": "^2.1.4",
     "lodash": "~2.4.0",
     "proxyquireify": "^3.0.0",
     "sinon": "~1.7.3",
diff --git a/plugins/jquery.js b/plugins/jquery.js
diff --git a/src/raven.js b/src/raven.js
@@ -619,9 +619,17 @@ Raven.prototype = {
                     }
                 });
                 origSend.apply(this, arguments);
-            }
+            };
         }
 
+        var $ = window.jQuery || window.$;
+        var origReady;
+        if ($ && $.fn && $.fn.ready) {
+            origReady = $.fn.ready;
+            $.fn.ready = function ravenjQueryReadyWrapper(fn) {
+                return origReady.call(this, self.wrap(fn));
+            };
+        }
     },
 
     _drainPlugins: function() {
diff --git a/test/index.html b/test/index.html
@@ -29,9 +29,6 @@
     });
     </script>
 
-    <!-- Deps -->
-    <script src="../node_modules/jquery/dist/jquery.js"></script>
-
     <!-- Tests -->
     <script src="../build/raven.test.js"></script>
 
diff --git a/test/plugins/jquery.test.js b/test/plugins/jquery.test.js
