build: Switch integrations, node, react, tracing to eslint (#2806)

* build: Switch @sentry/integrations to using eslint

* build: Remove tslint danger

* build: Switch @sentry/node to using eslint

* build: Switch @sentry/react to using eslint

* build: Switch @sentry/tracing to using eslint

* remove remaining tslint references

* Add unsafe any rule

Author: AbhiPrasad

.eslintignore

@@ -1,8 +1,4 @@
 # THIS IS A TEMPORARY FILE
 # THIS WILL BE REMOVED AFTER WE FINISH ESLINT UPGRADE
 
-packages/integrations/**/*
-packages/node/**/*
-packages/react/**/*
-packages/tracing/**/*
 packages/typescript/**/*

.eslintrc.js

@@ -4,8 +4,8 @@ module.exports = {
     node: true,
   },
   extends: ['prettier', 'eslint:recommended', 'plugin:import/errors', 'plugin:import/warnings'],
-  plugins: ['sentry-sdk', 'simple-import-sort'],
-  ignorePatterns: ['eslint-plugin-sentry-sdk'],
+  plugins: ['sentry-sdks', 'simple-import-sort'],
+  ignorePatterns: ['eslint-plugin-sentry-sdks'],
   overrides: [
     {
       // Configuration for JavaScript files
@@ -43,7 +43,7 @@ module.exports = {
         // Enforce type annotations to maintain consistency. This is especially important as
         // we have a public API, so we want changes to be very explicit.
         '@typescript-eslint/typedef': ['error', { arrowParameter: false }],
-        '@typescript-eslint/explicit-function-return-type': 'error',
+        '@typescript-eslint/explicit-function-return-type': ['error', { allowExpressions: true }],
 
         // Consistent ordering of fields, methods and constructors for classes should be enforced
         '@typescript-eslint/member-ordering': 'error',
@@ -87,21 +87,35 @@ module.exports = {
         'simple-import-sort/sort': 'error',
         'sort-imports': 'off',
         'import/order': 'off',
+
+        // Disallow delete operator. We should make this operation opt in (by disabling this rule).
+        '@typescript-eslint/no-dynamic-delete': 'error',
+
+        // We should prevent against overloads unless necessary.
+        '@typescript-eslint/unified-signatures': 'error',
+
+        // Disallow unsafe any usage. We should enforce that types be used as possible, or unknown be used
+        // instead of any. This is especially important for methods that expose a public API, as users
+        // should know exactly what they have to provide to use those methods. Turned off in tests.
+        '@typescript-eslint/no-unsafe-member-access': 'error',
       },
     },
     {
       // Configuration for files under src
       files: ['src/**/*'],
       rules: {
         // We want to prevent async await usage in our files to prevent uncessary bundle size.
-        'sentry-sdk/no-async-await': 'error',
+        'sentry-sdks/no-async-await': 'error',
 
         // JSDOC comments are required for classes and methods. As we have a public facing codebase, documentation,
         // even if it may seems excessive at times, is important to emphasize. Turned off in tests.
         'jsdoc/require-jsdoc': [
           'error',
           { require: { ClassDeclaration: true, MethodDefinition: true }, checkConstructors: false },
         ],
+
+        // All imports should be accounted for
+        'import/no-extraneous-dependencies': 'error',
       },
     },
     {
@@ -116,6 +130,7 @@ module.exports = {
         '@typescript-eslint/explicit-function-return-type': 'off',
         'no-unused-expressions': 'off',
         '@typescript-eslint/no-unused-expressions': 'off',
+        '@typescript-eslint/no-unsafe-member-access': 'off',
       },
     },
     {
@@ -164,5 +179,8 @@ module.exports = {
 
     // imports should be ordered.
     'import/order': ['error', { 'newlines-between': 'always' }],
+
+    // Make sure for in loops check for properties
+    'guard-for-in': 'error',
   },
 };

.vscode/extensions.json

@@ -1,5 +1,5 @@
 {
   // See http://go.microsoft.com/fwlink/?LinkId=827846
   // for the documentation about the extensions.json format
-  "recommendations": ["esbenp.prettier-vscode", "ms-vscode.vscode-typescript-tslint-plugin", "dbaeumer.vscode-eslint"]
+  "recommendations": ["esbenp.prettier-vscode", "dbaeumer.vscode-eslint"]
 }

.vscode/settings.json

@@ -13,7 +13,6 @@
     "**/dist/": true
   },
   "typescript.tsdk": "./node_modules/typescript/lib",
-  "tslint.autoFixOnSave": true,
   "[json]": {
     "editor.formatOnType": false,
     "editor.formatOnPaste": false,

dangerfile.ts

@@ -1,12 +1,8 @@
 import { exec } from 'child_process';
 import { danger, fail, message, schedule, warn } from 'danger';
-import tslint from 'danger-plugin-tslint';
-import { prettyResults } from 'danger-plugin-tslint/dist/prettyResults';
 import { CLIEngine } from 'eslint';
-import { resolve } from 'path';
 import { promisify } from 'util';
 
-const PACKAGES = ['integrations', 'node'];
 const EXTENSIONS = ['.js', '.jsx', '.ts', '.tsx'];
 
 /**
@@ -48,35 +44,6 @@ export default async (): Promise<void> => {
     return;
   }
 
-  schedule(async () => {
-    const tsLintResult = (
-      await Promise.all(
-        PACKAGES.map(packageName => {
-          return new Promise<string>(res => {
-            tslint({
-              lintResultsJsonPath: resolve(__dirname, 'packages', packageName, 'lint-results.json'),
-              handleResults: results => {
-                if (results.length > 0) {
-                  const formattedResults = prettyResults(results);
-                  res(`TSLint failed: **@sentry/${packageName}**\n\n${formattedResults}`);
-                } else {
-                  res('');
-                }
-              },
-            });
-          });
-        }),
-      )
-    ).filter(str => str.length);
-    if (tsLintResult.length) {
-      tsLintResult.forEach(tsLintFail => {
-        fail(`${tsLintFail}`);
-      });
-    } else {
-      message('✅ TSLint passed');
-    }
-  });
-
   await eslint();
 
   const hasChangelog = danger.git.modified_files.indexOf('CHANGELOG.md') !== -1;

eslint-plugin-sentry-sdk/index.js renamed to eslint-plugin-sentry-sdks/index.js

@@ -1,5 +1,5 @@
 {
-  "name": "eslint-plugin-sentry-sdk",
+  "name": "eslint-plugin-sentry-sdks",
   "version": "0.0.1",
   "main": "index.js",
   "devDependencies": {

eslint-plugin-sentry-sdk/package.json renamed to eslint-plugin-sentry-sdks/package.json

@@ -9,7 +9,6 @@
     "fix": "lerna run --stream --concurrency 1 fix",
     "link:yarn": "lerna run --stream --concurrency 1 link:yarn",
     "lint": "lerna run --stream --concurrency 1 lint",
-    "lint:json": "lerna run --stream --concurrency 1 lint:tslint:json",
     "test": "lerna run --stream --concurrency 1 --sort test",
     "codecov": "codecov",
     "postpublish": "make publish-docs"
@@ -44,19 +43,17 @@
     "@types/mocha": "^5.2.0",
     "@types/node": "^11.13.7",
     "@types/sinon": "^7.0.11",
-    "@typescript-eslint/eslint-plugin": "^3.7.1",
-    "@typescript-eslint/parser": "^3.7.1",
+    "@typescript-eslint/eslint-plugin": "^3.9.0",
+    "@typescript-eslint/parser": "^3.9.0",
     "chai": "^4.1.2",
     "codecov": "^3.6.5",
     "danger": "^7.1.3",
-    "danger-plugin-eslint": "^0.1.0",
-    "danger-plugin-tslint": "^2.0.0",
     "eslint": "^7.5.0",
     "eslint-config-prettier": "^6.11.0",
     "eslint-plugin-deprecation": "^1.1.0",
     "eslint-plugin-import": "^2.22.0",
     "eslint-plugin-jsdoc": "^30.0.3",
-    "eslint-plugin-sentry-sdk": "file:./eslint-plugin-sentry-sdk",
+    "eslint-plugin-sentry-sdks": "file:./eslint-plugin-sentry-sdks",
     "eslint-plugin-simple-import-sort": "^5.0.3",
     "jest": "^24.7.1",
     "karma-browserstack-launcher": "^1.5.1",
@@ -71,10 +68,8 @@
     "sinon": "^7.3.2",
     "size-limit": "^4.5.5",
     "ts-jest": "^24.0.2",
-    "tslint": "5.16.0",
     "typedoc": "^0.14.2",
-    "typescript": "3.4.5",
-    "typescript-tslint-plugin": "^0.3.1"
+    "typescript": "3.4.5"
   },
   "resolutions": {
     "**/agent-base": "5"

package.json

@@ -30,7 +30,6 @@
     "prettier": "^1.17.0",
     "prettier-check": "^2.0.0",
     "rimraf": "^2.6.3",
-    "tslint": "^5.16.0",
     "typescript": "^3.5.1"
   },
   "scripts": {

packages/angular/package.json

@@ -78,7 +78,6 @@ class SentryErrorHandler implements AngularErrorHandler {
     // Allow custom overrides of extracting function
     if (this._options.extractor) {
       const defaultExtractor = this._defaultExtractor.bind(this);
-      // tslint:disable-next-line:no-unsafe-any
       return this._options.extractor(error, defaultExtractor);
     }