ref: Prevent instantiating unnecessary Date objects (#2442)

* ref: Prevent instantiating unnecessary Date objects

Use Date.now() instead of new Date().getTime().

Resources:

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/getTime
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/now

* fixed tests

Co-authored-by: Kamil Ogórek <kamil.ogorek@gmail.com>

Author: rhcarvalho

packages/node/test/transports/http.test.ts

@@ -98,9 +98,11 @@ describe('HTTPTransport', () => {
     const now = Date.now();
     const mock = jest
       .spyOn(Date, 'now')
+      // Initialize _disabledUntil attribute
+      .mockReturnValueOnce(now)
       // Check for first event
       .mockReturnValueOnce(now)
-      // Setting disableUntil
+      // Setting disabledUntil
       .mockReturnValueOnce(now)
       // Check for second event
       .mockReturnValueOnce(now + (retryAfterSeconds / 2) * 1000)

packages/node/test/transports/https.test.ts

@@ -104,9 +104,11 @@ describe('HTTPSTransport', () => {
     const now = Date.now();
     const mock = jest
       .spyOn(Date, 'now')
+      // Initialize _disabledUntil attribute
+      .mockReturnValueOnce(now)
       // Check for first event
       .mockReturnValueOnce(now)
-      // Setting disableUntil
+      // Setting disabledUntil
       .mockReturnValueOnce(now)
       // Check for second event
       .mockReturnValueOnce(now + (retryAfterSeconds / 2) * 1000)

packages/utils/src/misc.ts

@@ -350,7 +350,7 @@ function _htmlElementAsString(el: unknown): string {
  * Returns a timestamp in seconds with milliseconds precision.
  */
 export function timestampWithMs(): number {
-  return new Date().getTime() / 1000;
+  return Date.now() / 1000;
 }
 
 // https://semver.org/#is-there-a-suggested-regular-expression-regex-to-check-a-semver-string