test: Add tests to decycle non-enum props

Author: kamilogorek

CHANGELOG.md

@@ -2,10 +2,11 @@
 
 ## Unreleased
 
-- [browser] fix: DOMError and DOMException should be error level events
-- [utils] fix: Dont mutate original input in decycle util function
-- [utils] ref: Update wrap method to hide internal sentry flags
-- [utils] fix: Make internal Sentry flags non-enumerable in fill util
+- [browser] fix: `DOMError` and `DOMException` should be error level events
+- [utils] fix: Dont mutate original input in `decycle` util function
+- [utils] fix: Skip non-enumerable properties in `decycle` util function
+- [utils] ref: Update `wrap` method to hide internal Sentry flags
+- [utils] fix: Make internal Sentry flags non-enumerable in `fill` util
 
 ## 4.5.3
 

packages/utils/src/object.ts

@@ -336,7 +336,7 @@ export function decycle(obj: any, memo: Memo = new Memo()): any {
     // tslint:disable-next-line
     for (const key in obj) {
       // Avoid iterating over fields in the prototype if they've somehow been exposed to enumeration.
-      if (!obj.hasOwnProperty(key)) {
+      if (!Object.prototype.hasOwnProperty.call(obj, key)) {
         continue;
       }
       // tslint:disable-next-line

packages/utils/test/object.test.ts

@@ -113,6 +113,29 @@ describe('decycle()', () => {
     expect(circular.qux).toBe(circular.bar[0].baz);
     expect(decycled).not.toBe(circular);
   });
+
+  test('skip non-enumerable properties', () => {
+    const circular = {
+      foo: 1,
+    };
+    circular.bar = circular;
+    Object.defineProperty(circular, 'baz', {
+      enumerable: true,
+      value: circular
+    });
+    Object.defineProperty(circular, 'qux', {
+      enumerable: false,
+      value: circular
+    });
+
+    const decycled = decycle(circular);
+
+    expect(decycled).toEqual({
+      bar: '[Circular ~]',
+      baz: '[Circular ~]',
+      foo: 1,
+    });
+  });
 });
 
 describe('serialize()', () => {