fix: Update handling of console breadcrumb arguments (#1741)

* fix: Missing breadcrumb argument

* fix: Serialize only 2 levels of console breadcrumb arguments

Author: kamilogorek

packages/browser/src/integrations/breadcrumbs.ts

@@ -3,7 +3,7 @@ import { Breadcrumb, Integration, SentryBreadcrumbHint, Severity } from '@sentry
 import { isFunction, isString } from '@sentry/utils/is';
 import { logger } from '@sentry/utils/logger';
 import { getEventDescription, getGlobalObject, parseUrl } from '@sentry/utils/misc';
-import { deserialize, fill } from '@sentry/utils/object';
+import { deserialize, fill, serializeObject } from '@sentry/utils/object';
 import { includes, safeJoin } from '@sentry/utils/string';
 import { supportsBeacon, supportsHistory, supportsNativeFetch } from '@sentry/utils/supports';
 import { BrowserClient } from '../client';
@@ -130,7 +130,7 @@ export class Breadcrumbs implements Integration {
             category: 'console',
             data: {
               extra: {
-                arguments: args.slice(1),
+                arguments: serializeObject(args, 2),
               },
               logger: 'console',
             },
@@ -141,7 +141,7 @@ export class Breadcrumbs implements Integration {
           if (level === 'assert') {
             if (args[0] === false) {
               breadcrumbData.message = `Assertion failed: ${safeJoin(args.slice(1), ' ') || 'console.assert'}`;
-              breadcrumbData.data.extra.arguments = args.slice(1);
+              breadcrumbData.data.extra.arguments = serializeObject(args.slice(1), 2);
             }
           }
 

packages/browser/test/integration/console-logs.js

@@ -1,6 +1,6 @@
 console.log('One');
 console.warn('Two', { a: 1 });
-console.error('Error 2');
+console.error('Error 2', { b: { c: 1 } });
 function a() {
   throw new Error('Error thrown 3');
 }

packages/browser/test/integration/test.js

@@ -1422,6 +1422,9 @@ for (var idx in frames) {
                 var sentryData = iframe.contentWindow.sentryData[0];
                 assert.ok(sentryData.breadcrumbs);
                 assert.lengthOf(sentryData.breadcrumbs, 3);
+                assert.deepEqual(sentryData.breadcrumbs[0].data.extra.arguments, ['One']);
+                assert.deepEqual(sentryData.breadcrumbs[1].data.extra.arguments, ['Two', { a: 1 }]);
+                assert.deepEqual(sentryData.breadcrumbs[2].data.extra.arguments, ['Error 2', { b: '[Object]' }]);
                 done();
               }
             }

packages/utils/src/object.ts

@@ -181,10 +181,8 @@ export function urlEncode(object: { [key: string]: any }): string {
 
 // Default Node.js REPL depth
 const MAX_SERIALIZE_EXCEPTION_DEPTH = 3;
-// TODO: Or is it 200kb? 🤔 — Kamil
-// NOTE: Yes, it is
-// 50kB, as 100kB is max payload size, so half sounds reasonable
-const MAX_SERIALIZE_EXCEPTION_SIZE = 50 * 1024;
+// 100kB, as 200kB is max payload size, so half sounds reasonable
+const MAX_SERIALIZE_EXCEPTION_SIZE = 100 * 1024;
 const MAX_SERIALIZE_KEYS_LENGTH = 40;
 
 /** JSDoc */