Add integration tests for setExtra (#4348)

onurtemizkan · web-flow · commit 698d631e6ab2 · 2021-12-21T11:44:11.000-05:00
diff --git a/packages/integration-tests/suites/public-api/setExtra/init.js b/packages/integration-tests/suites/public-api/setExtra/init.js
@@ -0,0 +1,7 @@
+import * as Sentry from '@sentry/browser';
+
+window.Sentry = Sentry;
+
+Sentry.init({
+  dsn: 'https://public@dsn.ingest.sentry.io/1337',
+});
diff --git a/packages/integration-tests/suites/public-api/setExtra/multiple_extras/subject.js b/packages/integration-tests/suites/public-api/setExtra/multiple_extras/subject.js
@@ -0,0 +1,10 @@
+Sentry.setExtra('extra_1', {
+  foo: 'bar',
+  baz: {
+    qux: 'quux',
+  },
+});
+
+Sentry.setExtra('extra_2', false);
+
+Sentry.captureMessage('multiple_extras');
diff --git a/packages/integration-tests/suites/public-api/setExtra/multiple_extras/test.ts b/packages/integration-tests/suites/public-api/setExtra/multiple_extras/test.ts
@@ -0,0 +1,13 @@
+import { expect } from '@playwright/test';
+
+import { sentryTest } from '../../../../utils/fixtures';
+import { getSentryRequest } from '../../../../utils/helpers';
+
+sentryTest('should record multiple extras of different types', async ({ getLocalTestPath, page }) => {
+  const url = await getLocalTestPath({ testDir: __dirname });
+
+  const eventData = await getSentryRequest(page, url);
+
+  expect(eventData.message).toBe('multiple_extras');
+  expect(eventData.extra).toMatchObject({ extra_1: { foo: 'bar', baz: { qux: 'quux' } }, extra_2: false });
+});
diff --git a/packages/integration-tests/suites/public-api/setExtra/non_serializable_extra/subject.js b/packages/integration-tests/suites/public-api/setExtra/non_serializable_extra/subject.js
@@ -0,0 +1,5 @@
+const el = document.querySelector('body');
+
+Sentry.setExtra('non_serializable', el);
+
+Sentry.captureMessage('non_serializable');
diff --git a/packages/integration-tests/suites/public-api/setExtra/non_serializable_extra/test.ts b/packages/integration-tests/suites/public-api/setExtra/non_serializable_extra/test.ts
@@ -0,0 +1,13 @@
+import { expect } from '@playwright/test';
+
+import { sentryTest } from '../../../../utils/fixtures';
+import { getSentryRequest } from '../../../../utils/helpers';
+
+sentryTest('should normalize non-serializable extra', async ({ getLocalTestPath, page }) => {
+  const url = await getLocalTestPath({ testDir: __dirname });
+
+  const eventData = await getSentryRequest(page, url);
+
+  expect(eventData.message).toBe('non_serializable');
+  expect(eventData.extra).toMatchObject({});
+});
diff --git a/packages/integration-tests/suites/public-api/setExtra/simple_extra/subject.js b/packages/integration-tests/suites/public-api/setExtra/simple_extra/subject.js
@@ -0,0 +1,8 @@
+Sentry.setExtra('simple_extra', {
+  foo: 'bar',
+  baz: {
+    qux: 'quux',
+  },
+});
+
+Sentry.captureMessage('simple_extra');
diff --git a/packages/integration-tests/suites/public-api/setExtra/simple_extra/test.ts b/packages/integration-tests/suites/public-api/setExtra/simple_extra/test.ts
@@ -0,0 +1,13 @@
+import { expect } from '@playwright/test';
+
+import { sentryTest } from '../../../../utils/fixtures';
+import { getSentryRequest } from '../../../../utils/helpers';
+
+sentryTest('should record a simple extra object', async ({ getLocalTestPath, page }) => {
+  const url = await getLocalTestPath({ testDir: __dirname });
+
+  const eventData = await getSentryRequest(page, url);
+
+  expect(eventData.message).toBe('simple_extra');
+  expect(eventData.extra).toMatchObject({ simple_extra: { foo: 'bar', baz: { qux: 'quux' } } });
+});
diff --git a/packages/integration-tests/suites/public-api/setExtra/template.hbs b/packages/integration-tests/suites/public-api/setExtra/template.hbs
@@ -0,0 +1,11 @@
+<!DOCTYPE html>
+<html>
+  <head>
+    <meta charset="utf-8" />
+    <title></title>
+  <script src="{{htmlWebpackPlugin.options.initialization}}"></script>
+  </head>
+  <body>
+    <script src="{{htmlWebpackPlugin.options.subject}}"></script>
+  </body>
+</html>
