feat(feedback): Return the eventId into the onSubmitSuccess callback (#16835)

Fixes #16836

Author: ryan953

packages/core/src/types-hoist/feedback/config.ts

@@ -197,7 +197,7 @@ export interface FeedbackCallbacks {
    *
    * After this you'll see a SuccessMessage on the screen for a moment.
    */
-  onSubmitSuccess?: (data: FeedbackFormData) => void;
+  onSubmitSuccess?: (data: FeedbackFormData, eventId: string) => void;
 
   /**
    * Callback when feedback is unsuccessfully submitted

packages/feedback/src/modal/components/Dialog.tsx

@@ -30,8 +30,8 @@ export function Dialog({ open, onFormSubmitted, ...props }: Props): VNode {
   }, [timeoutId]);
 
   const onSubmitSuccess = useCallback(
-    (data: FeedbackFormData) => {
-      props.onSubmitSuccess(data);
+    (data: FeedbackFormData, eventId: string) => {
+      props.onSubmitSuccess(data, eventId);
       setTimeoutId(
         setTimeout(() => {
           onFormSubmitted();

packages/feedback/src/modal/components/Form.tsx

@@ -18,7 +18,7 @@ export interface Props extends Pick<FeedbackInternalOptions, 'showEmail' | 'show
   defaultName: string;
   onFormClose: () => void;
   onSubmit: SendFeedback;
-  onSubmitSuccess: (data: FeedbackFormData) => void;
+  onSubmitSuccess: (data: FeedbackFormData, eventId: string) => void;
   onSubmitError: (error: Error) => void;
   screenshotInput: ReturnType<FeedbackScreenshotIntegration['createInput']> | undefined;
 }
@@ -118,7 +118,7 @@ export function Form({
         }
 
         try {
-          await onSubmit(
+          const eventId = await onSubmit(
             {
               name: data.name,
               email: data.email,
@@ -128,7 +128,7 @@ export function Form({
             },
             { attachments: data.attachments },
           );
-          onSubmitSuccess(data);
+          onSubmitSuccess(data, eventId);
         } catch (error) {
           DEBUG_BUILD && logger.error(error);
           setError(error as string);

packages/feedback/src/modal/integration.tsx

@@ -77,9 +77,9 @@ export const feedbackModalIntegration = ((): FeedbackModalIntegration => {
               options.onFormClose?.();
             }}
             onSubmit={sendFeedback}
-            onSubmitSuccess={(data: FeedbackFormData) => {
+            onSubmitSuccess={(data: FeedbackFormData, eventId: string) => {
               renderContent(false);
-              options.onSubmitSuccess?.(data);
+              options.onSubmitSuccess?.(data, eventId);
             }}
             onSubmitError={(error: Error) => {
               options.onSubmitError?.(error);

packages/feedback/src/util/mergeOptions.ts

@@ -23,9 +23,9 @@ export function mergeOptions(
       optionOverrides.onFormClose?.();
       defaultOptions.onFormClose?.();
     },
-    onSubmitSuccess: (data: FeedbackFormData) => {
-      optionOverrides.onSubmitSuccess?.(data);
-      defaultOptions.onSubmitSuccess?.(data);
+    onSubmitSuccess: (data: FeedbackFormData, eventId: string) => {
+      optionOverrides.onSubmitSuccess?.(data, eventId);
+      defaultOptions.onSubmitSuccess?.(data, eventId);
     },
     onSubmitError: (error: Error) => {
       optionOverrides.onSubmitError?.(error);