todo comment and update interactionIdtoRouteNameMapping replay to replayid

Author: edwardgou-sentry

packages/browser/src/profiling/utils.ts

@@ -583,6 +583,9 @@ export function createProfilingEvent(
   return createProfilePayload(profile_id, start_timestamp, profile, event);
 }
 
+// TODO (v8): We need to obtain profile ids in @sentry-internal/tracing,
+// but we don't have access to this map because importing this map would
+// cause a circular dependancy. We need to resolve this in v8.
 const PROFILE_MAP: Map<string, JSSelfProfile> = new Map();
 /**
  *

packages/tracing-internal/src/browser/browserTracingIntegration.ts

@@ -547,6 +547,7 @@ function registerInpInteractionListener(
       client !== undefined && client.getIntegrationByName !== undefined
         ? (client.getIntegrationByName('Replay') as Integration & { getReplayId: () => string })
         : undefined;
+    const replayId = replay !== undefined ? replay.getReplayId() : undefined;
     // eslint-disable-next-line deprecation/deprecation
     const activeTransaction = getActiveTransaction();
     const currentScope = getCurrentScope();
@@ -578,7 +579,7 @@ function registerInpInteractionListener(
               parentContext,
               user,
               activeTransaction,
-              replay,
+              replayId,
             };
           }
         }

packages/tracing-internal/src/browser/metrics/index.ts

@@ -213,20 +213,19 @@ function _trackINP(interactionIdtoRouteNameMapping: InteractionRouteNameMapping)
     /** Build the INP span, create an envelope from the span, and then send the envelope */
     const startTime = msToSec((browserPerformanceTimeOrigin as number) + entry.startTime);
     const duration = msToSec(metric.value);
-    const { routeName, parentContext, activeTransaction, user, replay } =
+    const { routeName, parentContext, activeTransaction, user, replayId } =
       entry.interactionId !== undefined
         ? interactionIdtoRouteNameMapping[entry.interactionId]
         : {
             routeName: undefined,
             parentContext: undefined,
             activeTransaction: undefined,
             user: undefined,
-            replay: undefined,
+            replayId: undefined,
           };
     const userDisplay = user !== undefined ? user.email || user.id || user.ip_address : undefined;
     // eslint-disable-next-line deprecation/deprecation
     const profileId = activeTransaction !== undefined ? activeTransaction.getProfileId() : undefined;
-    const replayId = replay !== undefined ? replay.getReplayId() : undefined;
     const span = new Span({
       startTimestamp: startTime,
       endTimestamp: startTime + duration,

packages/tracing-internal/src/browser/web-vitals/types.ts

@@ -171,6 +171,6 @@ export type InteractionRouteNameMapping = {
     parentContext: TransactionContext;
     user?: User;
     activeTransaction?: Transaction;
-    replay?: Integration & { getReplayId: () => string };
+    replayId?: string;
   };
 };