fix: Use Class.id internally (#1674)

HazAT · web-flow · commit 65965ff30b4c · 2018-10-23T15:17:33.000+02:00
* fix: Use Class.id internally

* meta: Add changelog
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,9 @@
 # Changelog
 
 ## Unreleased
+## 4.2.2
+
+- [core]: "De-deprecate" name of `Integration` interface.
 
 ## 4.2.1
 
diff --git a/packages/browser/src/integrations/breadcrumbs.ts b/packages/browser/src/integrations/breadcrumbs.ts
@@ -38,7 +38,7 @@ export class Breadcrumbs implements Integration {
   /**
    * @inheritDoc
    */
-  public name: string = 'Breadcrumbs';
+  public name: string = Breadcrumbs.id;
 
   /**
    * @inheritDoc
diff --git a/packages/browser/src/integrations/globalhandlers.ts b/packages/browser/src/integrations/globalhandlers.ts
@@ -21,7 +21,7 @@ export class GlobalHandlers implements Integration {
   /**
    * @inheritDoc
    */
-  public name: string = 'GlobalHandlers';
+  public name: string = GlobalHandlers.id;
 
   /**
    * @inheritDoc
diff --git a/packages/browser/src/integrations/linkederrors.ts b/packages/browser/src/integrations/linkederrors.ts
@@ -18,7 +18,7 @@ export class LinkedErrors implements Integration {
   /**
    * @inheritDoc
    */
-  public readonly name: string = 'LinkedErrors';
+  public readonly name: string = LinkedErrors.id;
 
   /**
    * @inheritDoc
diff --git a/packages/browser/src/integrations/pluggable/ember.ts b/packages/browser/src/integrations/pluggable/ember.ts
@@ -7,7 +7,7 @@ export class Ember implements Integration {
   /**
    * @inheritDoc
    */
-  public name: string = 'Ember';
+  public name: string = Ember.id;
   /**
    * @inheritDoc
    */
diff --git a/packages/browser/src/integrations/pluggable/vue.ts b/packages/browser/src/integrations/pluggable/vue.ts
@@ -18,7 +18,7 @@ export class Vue implements Integration {
   /**
    * @inheritDoc
    */
-  public name: string = 'Vue';
+  public name: string = Vue.id;
   /**
    * @inheritDoc
    */
diff --git a/packages/browser/src/integrations/reportingobserver.ts b/packages/browser/src/integrations/reportingobserver.ts
@@ -57,7 +57,7 @@ export class ReportingObserver implements Integration {
   /**
    * @inheritDoc
    */
-  public readonly name: string = 'ReportingObserver';
+  public readonly name: string = ReportingObserver.id;
   /**
    * @inheritDoc
    */
diff --git a/packages/browser/src/integrations/trycatch.ts b/packages/browser/src/integrations/trycatch.ts
@@ -11,7 +11,7 @@ export class TryCatch implements Integration {
   /**
    * @inheritDoc
    */
-  public name: string = 'TryCatch';
+  public name: string = TryCatch.id;
 
   /**
    * @inheritDoc
diff --git a/packages/browser/src/integrations/useragent.ts b/packages/browser/src/integrations/useragent.ts
@@ -9,7 +9,7 @@ export class UserAgent implements Integration {
   /**
    * @inheritDoc
    */
-  public name: string = 'UserAgent';
+  public name: string = UserAgent.id;
 
   /**
    * @inheritDoc
diff --git a/packages/core/src/integrations/dedupe.ts b/packages/core/src/integrations/dedupe.ts
@@ -13,7 +13,7 @@ export class Dedupe implements Integration {
   /**
    * @inheritDoc
    */
-  public name: string = 'Dedupe';
+  public name: string = Dedupe.id;
 
   /**
    * @inheritDoc
diff --git a/packages/core/src/integrations/functiontostring.ts b/packages/core/src/integrations/functiontostring.ts
@@ -7,7 +7,13 @@ export class FunctionToString implements Integration {
   /**
    * @inheritDoc
    */
-  public name: string = 'FunctionToString';
+  public name: string = FunctionToString.id;
+
+  /**
+   * @inheritDoc
+   */
+  public static id: string = 'FunctionToString';
+
   /**
    * @inheritDoc
    */
diff --git a/packages/core/src/integrations/inboundfilters.ts b/packages/core/src/integrations/inboundfilters.ts
@@ -28,7 +28,7 @@ export class InboundFilters implements Integration {
   /**
    * @inheritDoc
    */
-  public name: string = 'InboundFilters';
+  public name: string = InboundFilters.id;
   /**
    * @inheritDoc
    */
diff --git a/packages/core/src/integrations/pluggable/debug.ts b/packages/core/src/integrations/pluggable/debug.ts
@@ -12,7 +12,7 @@ export class Debug implements Integration {
   /**
    * @inheritDoc
    */
-  public name: string = 'Debug';
+  public name: string = Debug.id;
 
   /**
    * @inheritDoc
diff --git a/packages/core/src/integrations/pluggable/rewriteframes.ts b/packages/core/src/integrations/pluggable/rewriteframes.ts
@@ -9,7 +9,7 @@ export class RewriteFrames implements Integration {
   /**
    * @inheritDoc
    */
-  public name: string = 'RewriteFrames';
+  public name: string = RewriteFrames.id;
 
   /**
    * @inheritDoc
diff --git a/packages/node/src/integrations/console.ts b/packages/node/src/integrations/console.ts
@@ -8,7 +8,7 @@ export class Console implements Integration {
   /**
    * @inheritDoc
    */
-  public name: string = 'Console';
+  public name: string = Console.id;
   /**
    * @inheritDoc
    */
diff --git a/packages/node/src/integrations/http.ts b/packages/node/src/integrations/http.ts
@@ -19,7 +19,7 @@ export class Http implements Integration {
   /**
    * @inheritDoc
    */
-  public name: string = 'Http';
+  public name: string = Http.id;
   /**
    * @inheritDoc
    */
diff --git a/packages/node/src/integrations/linkederrors.ts b/packages/node/src/integrations/linkederrors.ts
@@ -17,7 +17,7 @@ export class LinkedErrors implements Integration {
   /**
    * @inheritDoc
    */
-  public readonly name: string = 'LinkedErrors';
+  public readonly name: string = LinkedErrors.id;
   /**
    * @inheritDoc
    */
diff --git a/packages/node/src/integrations/onuncaughtexception.ts b/packages/node/src/integrations/onuncaughtexception.ts
@@ -8,7 +8,7 @@ export class OnUncaughtException implements Integration {
   /**
    * @inheritDoc
    */
-  public name: string = 'OnUncaughtException';
+  public name: string = OnUncaughtException.id;
   /**
    * @inheritDoc
    */
diff --git a/packages/node/src/integrations/onunhandledrejection.ts b/packages/node/src/integrations/onunhandledrejection.ts
@@ -6,7 +6,7 @@ export class OnUnhandledRejection implements Integration {
   /**
    * @inheritDoc
    */
-  public name: string = 'OnUnhandledRejection';
+  public name: string = OnUnhandledRejection.id;
   /**
    * @inheritDoc
    */
diff --git a/packages/node/src/integrations/pluggable/modules.ts b/packages/node/src/integrations/pluggable/modules.ts
@@ -9,7 +9,7 @@ export class Modules implements Integration {
   /**
    * @inheritDoc
    */
-  public name: string = 'Modules';
+  public name: string = Modules.id;
   /**
    * @inheritDoc
    */
diff --git a/packages/node/src/integrations/pluggable/transaction.ts b/packages/node/src/integrations/pluggable/transaction.ts
@@ -6,7 +6,7 @@ export class Transaction implements Integration {
   /**
    * @inheritDoc
    */
-  public name: string = 'Transaction';
+  public name: string = Transaction.id;
   /**
    * @inheritDoc
    */
diff --git a/packages/types/src/index.ts b/packages/types/src/index.ts
@@ -195,9 +195,8 @@ export interface Mechanism {
 
 /** Integration interface */
 export interface Integration {
-  // TODO: Remove with v5
   /**
-   * @deprecated Use {@link IntegrationClass.id} instead
+   * Returns {@link IntegrationClass.id}
    */
   name: string;
   // TODO: Remove with v5
diff --git a/scripts/pack-and-upload.sh b/scripts/pack-and-upload.sh
@@ -5,15 +5,17 @@ yarn global add @zeus-ci/cli
 yarn
 yarn build
 
-# Sanity Check
-yarn lerna changed --include-merged-tags -p
-
 # Temp workaround
+############################################
 git clone https://github.com/HazAT/lerna.git
 cd lerna
 npm link
 cd ../
 npm link lerna
+
+# Sanity Check
+yarn lerna changed --include-merged-tags -p
+
 ############################################
 
 # Upload NPM packages
