Fix lint issue and tests

Author: RulaKhaled

packages/react-router/src/vite/plugin.ts

@@ -1,9 +1,9 @@
 import type { ConfigEnv } from 'vite';
 import { type Plugin } from 'vite';
+import { makeConfigInjectorPlugin } from './makeConfigInjectorPlugin';
 import { makeCustomSentryVitePlugins } from './makeCustomSentryVitePlugins';
 import { makeEnableSourceMapsPlugin } from './makeEnableSourceMapsPlugin';
 import type { SentryReactRouterBuildOptions } from './types';
-import { makeConfigInjectorPlugin } from './makeConfigInjectorPlugin';
 
 /**
  * A Vite plugin for Sentry that handles source map uploads and bundle size optimizations.

packages/react-router/test/vite/plugin.test.ts

@@ -1,4 +1,5 @@
 import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
+import { makeConfigInjectorPlugin } from '../../src/vite/makeConfigInjectorPlugin';
 import { makeCustomSentryVitePlugins } from '../../src/vite/makeCustomSentryVitePlugins';
 import { makeEnableSourceMapsPlugin } from '../../src/vite/makeEnableSourceMapsPlugin';
 import { sentryReactRouter } from '../../src/vite/plugin';
@@ -12,57 +13,61 @@ vi.spyOn(console, 'warn').mockImplementation(() => {
 
 vi.mock('../../src/vite/makeCustomSentryVitePlugins');
 vi.mock('../../src/vite/makeEnableSourceMapsPlugin');
+vi.mock('../../src/vite/makeConfigInjectorPlugin');
 
 describe('sentryReactRouter', () => {
   const mockPlugins = [{ name: 'test-plugin' }];
   const mockSourceMapsPlugin = { name: 'source-maps-plugin' };
+  const mockConfigInjectorPlugin = { name: 'sentry-config-injector' };
 
   beforeEach(() => {
     vi.clearAllMocks();
     vi.mocked(makeCustomSentryVitePlugins).mockResolvedValue(mockPlugins);
     vi.mocked(makeEnableSourceMapsPlugin).mockReturnValue(mockSourceMapsPlugin);
+    vi.mocked(makeConfigInjectorPlugin).mockReturnValue(mockConfigInjectorPlugin);
   });
 
   afterEach(() => {
     vi.resetModules();
   });
 
-  it('should return an empty array in development mode', async () => {
+  it('should return sentry config injector plugin in development mode', async () => {
     const originalNodeEnv = process.env.NODE_ENV;
     process.env.NODE_ENV = 'development';
 
     const result = await sentryReactRouter({}, { command: 'build', mode: 'production' });
 
-    expect(result).toEqual([]);
+    expect(result).toEqual([mockConfigInjectorPlugin]);
     expect(makeCustomSentryVitePlugins).not.toHaveBeenCalled();
     expect(makeEnableSourceMapsPlugin).not.toHaveBeenCalled();
 
     process.env.NODE_ENV = originalNodeEnv;
   });
 
-  it('should return an empty array when not in build mode', async () => {
+  it('should return config injector plugin when not in build mode', async () => {
     const result = await sentryReactRouter({}, { command: 'serve', mode: 'production' });
 
-    expect(result).toEqual([]);
+    expect(result).toEqual([mockConfigInjectorPlugin]);
     expect(makeCustomSentryVitePlugins).not.toHaveBeenCalled();
     expect(makeEnableSourceMapsPlugin).not.toHaveBeenCalled();
   });
 
-  it('should return an empty array when in development mode', async () => {
+  it('should return config injector plugin in development build mode', async () => {
     const result = await sentryReactRouter({}, { command: 'build', mode: 'development' });
 
-    expect(result).toEqual([]);
+    expect(result).toEqual([mockConfigInjectorPlugin]);
     expect(makeCustomSentryVitePlugins).not.toHaveBeenCalled();
     expect(makeEnableSourceMapsPlugin).not.toHaveBeenCalled();
   });
 
-  it('should return plugins in production build mode', async () => {
+  it('should return all plugins in production build mode', async () => {
     const originalNodeEnv = process.env.NODE_ENV;
     process.env.NODE_ENV = 'production';
 
     const result = await sentryReactRouter({}, { command: 'build', mode: 'production' });
 
-    expect(result).toEqual([mockSourceMapsPlugin, ...mockPlugins]);
+    expect(result).toEqual([mockConfigInjectorPlugin, mockSourceMapsPlugin, ...mockPlugins]);
+    expect(makeConfigInjectorPlugin).toHaveBeenCalledWith({});
     expect(makeCustomSentryVitePlugins).toHaveBeenCalledWith({});
     expect(makeEnableSourceMapsPlugin).toHaveBeenCalledWith({});
 
@@ -81,6 +86,7 @@ describe('sentryReactRouter', () => {
 
     await sentryReactRouter(options, { command: 'build', mode: 'production' });
 
+    expect(makeConfigInjectorPlugin).toHaveBeenCalledWith(options);
     expect(makeCustomSentryVitePlugins).toHaveBeenCalledWith(options);
     expect(makeEnableSourceMapsPlugin).toHaveBeenCalledWith(options);