fix: make addBreadcrumb sync (#1649)

Author: HazAT

CHANGELOG.md

@@ -2,7 +2,8 @@
 
 ## Unreleased
 
-- [tbd] tbd
+- [browser] fix: Make `addBreadcrumb` sync internally, `beforeBreadcrumb` is now only sync
+- [browser] fix: Remove internal `console` guard in `beforeBreadcrumb`
 
 ## 4.1.1
 

packages/browser/test/integration/console-logs.js

@@ -0,0 +1,7 @@
+console.log('One');
+console.warn('Two', { a: 1 });
+console.error('Error 2');
+let a = () => {
+  throw new Error('Error thrown 3');
+};
+a();

packages/browser/test/integration/init.js

@@ -40,6 +40,9 @@ Sentry.init({
   //   return [new Sentry.Integrations.Debug({ stringify: true })].concat(old);
   // },
   beforeBreadcrumb: function(breadcrumb) {
+    if (window.forceAllBreadcrumbs) {
+      return breadcrumb;
+    }
     // Filter console logs as we use them for debugging *a lot* and they are not *that* important
     if (breadcrumb.category === 'console') {
       return null;