feat: Introduce hub (#1364)

* feat: Introduce hub

* feat: Move function from global to hub

* feat: Move everything into hub

* feat: Rename shim to hub, Move shim global code into new package minimal

* feat: Rewrite to use hub/minimal

* feat: Fix browser/core for while using hub

* feat: Change node to use hub, Create node specific hub

* fix: Linter error and wrong imports

* ref: Change scope lister to add processor

* ref: Rename scope processor to listener

* fix: Tests and carrier hub

* feat: Configure scope should pass it to the hub

Author: HazAT

package.json

@@ -11,8 +11,9 @@
   "workspaces": [
     "packages/browser",
     "packages/core",
+    "packages/hub",
+    "packages/minimal",
     "packages/node",
-    "packages/shim",
     "packages/types",
     "packages/typescript",
     "packages/utils"

packages/README.md

@@ -30,7 +30,9 @@ For each major JavaScript platform, there is a specific high-level SDK that
 provides all the tools you need in a single package. Please refer to the README
 and instructions of those SDKs for more detailed information:
 
-* [`@sentry/shim`](https://github.com/getsentry/raven-js/tree/master/packages/shim):
+* [`@sentry/hub`](https://github.com/getsentry/raven-js/tree/master/packages/hub):
+  Gobal state managment of SDKs
+* [`@sentry/minimal`](https://github.com/getsentry/raven-js/tree/master/packages/minimal):
   Minimal SDK for library authors to add Sentry support
 * [`@sentry/browser`](https://github.com/getsentry/raven-js/tree/master/packages/browser):
   SDK for Browsers, including integrations for React, Angular, Ember, Vue and

packages/browser/README.md

@@ -12,8 +12,8 @@
 [![npm dt](https://img.shields.io/npm/dt/@sentry/browser.svg)](https://www.npmjs.com/package/@sentry/browser)
 
 **WARNING:** This SDK is part of an early access preview for the
-[next generation](https://github.com/getsentry/raven-js/tree/next#readme) of
-Sentry JavaScript SDKs. Public interfaces might change and break backwards
+[next generation](https://github.com/getsentry/raven-js/tree/master/packages#readme)
+of Sentry JavaScript SDKs. Public interfaces might change and break backwards
 compatibility from time to time. We absolutely recommend
 [raven-js](https://github.com/getsentry/raven-js) in production!
 

packages/browser/package.json

@@ -3,7 +3,7 @@
   "version": "0.5.4",
   "description": "Offical Sentry SDK for browsers",
   "repository": "git://github.com/getsentry/raven-js.git",
-  "homepage": "https://github.com/getsentry/raven-js/tree/next/packages/browser",
+  "homepage": "https://github.com/getsentry/raven-js/tree/master/packages/browser",
   "author": "Sentry",
   "license": "BSD-3-Clause",
   "engines": {
@@ -16,7 +16,8 @@
   },
   "dependencies": {
     "@sentry/core": "0.5.4",
-    "@sentry/shim": "0.5.4",
+    "@sentry/hub": "0.5.4",
+    "@sentry/minimal": "0.5.4",
     "@sentry/types": "0.5.4"
   },
   "devDependencies": {
@@ -38,7 +39,6 @@
     "rollup-plugin-commonjs": "^9.1.3",
     "rollup-plugin-node-resolve": "^3.3.0",
     "rollup-plugin-npm": "^2.0.0",
-    "rollup-plugin-shim": "^1.0.0",
     "rollup-plugin-typescript2": "^0.13.0",
     "rollup-plugin-uglify": "^3.0.0",
     "sinon": "^5.0.3",

packages/browser/rollup.config.js

@@ -2,7 +2,6 @@ import commonjs from 'rollup-plugin-commonjs';
 import uglify from 'rollup-plugin-uglify';
 import resolve from 'rollup-plugin-node-resolve';
 import typescript from 'rollup-plugin-typescript2';
-import shim from 'rollup-plugin-shim';
 
 export default [
   {
@@ -13,7 +12,7 @@ export default [
       exports: 'named',
       interop: false,
     },
-    external: ['@sentry/core', '@sentry/shim'],
+    external: ['@sentry/core', '@sentry/hub', '@sentry/minimal'],
     plugins: [
       typescript({
         tsconfig: 'tsconfig.build.json',
@@ -48,9 +47,6 @@ export default [
         browser: true,
       }),
       commonjs(),
-      shim({
-        domain: `export var active = false;`,
-      }),
       uglify(),
     ],
   },

packages/browser/src/backend.ts

@@ -1,5 +1,5 @@
 import { Backend, Options, SentryError } from '@sentry/core';
-import { addBreadcrumb, captureEvent } from '@sentry/shim';
+import { addBreadcrumb, captureEvent } from '@sentry/minimal';
 import { SentryEvent, SentryException } from '@sentry/types';
 import { Raven, SendMethod } from './raven';
 

packages/browser/src/index.ts

@@ -17,11 +17,9 @@ export {
   captureException,
   captureEvent,
   configureScope,
-  popScope,
-  pushScope,
-  withScope,
-  Scope,
-} from '@sentry/shim';
+} from '@sentry/minimal';
+
+export { Hub, Scope } from '@sentry/hub';
 
 export { BrowserBackend, BrowserOptions } from './backend';
 export { BrowserClient } from './client';

packages/browser/src/integrations/onunhandledrejection.ts

@@ -1,4 +1,4 @@
-import { captureException } from '@sentry/shim';
+import { captureException } from '@sentry/minimal';
 import { Integration } from '@sentry/types';
 
 /** onunhandledrejection is not standardized, thus not available on Window type */

packages/browser/src/sdk.ts

@@ -1,5 +1,5 @@
 import { initAndBind } from '@sentry/core';
-import { getCurrentClient as shimGetCurrentClient } from '@sentry/shim';
+import { getCurrentClient as shimGetCurrentClient } from '@sentry/minimal';
 import { BrowserOptions } from './backend';
 import { BrowserClient } from './client';
 import {

packages/browser/test/index.test.ts

@@ -9,9 +9,8 @@ import {
   captureException,
   captureMessage,
   configureScope,
+  Hub,
   init,
-  popScope,
-  pushScope,
   Scope,
   SentryEvent,
 } from '../src';
@@ -26,19 +25,19 @@ describe('SentryBrowser', () => {
   });
 
   beforeEach(() => {
-    pushScope();
+    Hub.getGlobal().pushScope();
   });
 
   afterEach(() => {
-    popScope();
+    Hub.getGlobal().popScope();
   });
 
   describe('getContext() / setContext()', () => {
     it('should store/load extra', () => {
       configureScope((scope: Scope) => {
         scope.setExtra('abc', { def: [1] });
       });
-      expect(global.__SENTRY__.stack[1].scope.extra).to.deep.equal({
+      expect(global.__SENTRY__.hub.stack[1].scope.extra).to.deep.equal({
         abc: { def: [1] },
       });
     });
@@ -47,7 +46,7 @@ describe('SentryBrowser', () => {
       configureScope((scope: Scope) => {
         scope.setTag('abc', 'def');
       });
-      expect(global.__SENTRY__.stack[1].scope.tags).to.deep.equal({
+      expect(global.__SENTRY__.hub.stack[1].scope.tags).to.deep.equal({
         abc: 'def',
       });
     });
@@ -56,7 +55,7 @@ describe('SentryBrowser', () => {
       configureScope((scope: Scope) => {
         scope.setUser({ id: 'def' });
       });
-      expect(global.__SENTRY__.stack[1].scope.user).to.deep.equal({
+      expect(global.__SENTRY__.hub.stack[1].scope.user).to.deep.equal({
         id: 'def',
       });
     });
@@ -76,7 +75,7 @@ describe('SentryBrowser', () => {
     });
 
     it('should record auto breadcrumbs', done => {
-      pushScope(
+      Hub.getGlobal().pushScope(
         new BrowserClient({
           afterSend: (event: SentryEvent) => {
             expect(event.breadcrumbs!).to.have.lengthOf(3);
@@ -98,7 +97,7 @@ describe('SentryBrowser', () => {
       addBreadcrumb({ message: 'test2' });
 
       captureMessage('event');
-      popScope();
+      Hub.getGlobal().popScope();
     });
   });
 
@@ -116,7 +115,7 @@ describe('SentryBrowser', () => {
     });
 
     it('should capture an exception', done => {
-      pushScope(
+      Hub.getGlobal().pushScope(
         new BrowserClient({
           afterSend: (event: SentryEvent) => {
             expect(event.exception).to.not.be.undefined;
@@ -134,11 +133,11 @@ describe('SentryBrowser', () => {
       } catch (e) {
         captureException(e);
       }
-      popScope();
+      Hub.getGlobal().popScope();
     });
 
     it('should capture a message', done => {
-      pushScope(
+      Hub.getGlobal().pushScope(
         new BrowserClient({
           afterSend: (event: SentryEvent) => {
             expect(event.message).to.equal('test');
@@ -149,11 +148,11 @@ describe('SentryBrowser', () => {
         }),
       );
       captureMessage('test');
-      popScope();
+      Hub.getGlobal().popScope();
     });
 
     it('should capture an event', done => {
-      pushScope(
+      Hub.getGlobal().pushScope(
         new BrowserClient({
           afterSend: (event: SentryEvent) => {
             expect(event.message).to.equal('test');
@@ -164,7 +163,7 @@ describe('SentryBrowser', () => {
         }),
       );
       captureEvent({ message: 'test' });
-      popScope();
+      Hub.getGlobal().popScope();
     });
   });
 });