Skip to content

Commit 4f12c32

Browse files
authored
ci: Add iOS 10 and Android 4.4/5.1 SauceLabs configs (#1074)
1 parent cf546ac commit 4f12c32

File tree

2 files changed

+29
-5
lines changed

2 files changed

+29
-5
lines changed

Gruntfile.js

Lines changed: 23 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,8 @@ module.exports = function(grunt) {
204204
'http://127.0.0.1:9999/test/integration/index.html'
205205
],
206206
sauceConfig: {
207-
'record-video': false
207+
'record-video': false,
208+
'record-screenshots': false
208209
},
209210
build: process.env.TRAVIS_BUILD_NUMBER,
210211
// On average, our integration tests take 60s to run
@@ -218,17 +219,35 @@ module.exports = function(grunt) {
218219
'Raven.js' +
219220
(process.env.TRAVIS_JOB_NUMBER ? ' #' + process.env.TRAVIS_JOB_NUMBER : ''),
220221
browsers: [
221-
// Latest version of Edge (v15) can't reach the server
222+
// Latest version of Edge (v15) can't reach the server, so we use v14 for now instead
222223
// Already notified SauceLabs support about this issue
223-
// ['Windows 10', 'microsoftedge', 'latest'],
224224
['Windows 10', 'microsoftedge', 'latest-1'],
225+
225226
// We can skip IE11 on Win7, as there are no differences that'd change anything for us
226227
// https://msdn.microsoft.com/library/dn394063(v=vs.85).aspx#unsupported_features
227228
['Windows 10', 'internet explorer', '11'],
228229
['Windows 7', 'internet explorer', '10'],
229230
['Windows 10', 'chrome', 'latest'],
230231
['Windows 10', 'firefox', 'latest'],
231-
['macOS 10.12', 'safari', '10']
232+
['macOS 10.12', 'safari', '10.0'],
233+
['macOS 10.12', 'iphone', '10.0'],
234+
['Linux', 'android', '4.4'],
235+
['Linux', 'android', '5.1']
236+
237+
// grunt-saucelabs (or SauceLabs REST API?) doesn't allow for passing device attribute at the moment
238+
// and it's required for Android 6.0/7.1 - https://wiki.saucelabs.com/display/DOCS/2017/03/31/Android+6.0+and+7.0+Support+Released
239+
// Notified SauceLabs support as well, so hopefully it'll be resolved soon
240+
// {
241+
// browserName: 'Chrome',
242+
// platform: 'Android',
243+
// version: '6.0',
244+
// device: 'Android Emulator'
245+
// }, {
246+
// browserName: 'Chrome',
247+
// platform: 'Android',
248+
// version: '7.1',
249+
// device: 'Android GoogleAPI Emulator'
250+
// }
232251
],
233252
public: 'public',
234253
tunnelArgs: ['--verbose'],

test/integration/test.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -356,7 +356,12 @@ describe('integration', function() {
356356
function() {
357357
var ravenData = iframe.contentWindow.ravenData[0];
358358
assert.equal(ravenData.exception.values[0].type, undefined);
359-
assert.equal(ravenData.exception.values[0].value, '[object Object]');
359+
360+
// #<Object> is covering default Android 4.4 and 5.1 browser
361+
assert.match(
362+
ravenData.exception.values[0].value,
363+
/^(\[object Object\]|#<Object>)$/
364+
);
360365
assert.equal(ravenData.exception.values[0].stacktrace.frames.length, 1); // always 1 because thrown objects can't provide > 1 frame
361366

362367
// some browsers extract proper url, line, and column for thrown objects

0 commit comments

Comments
 (0)