feat: Add craft for releases (#1589)

Author: HazAT

.craft.yml

@@ -0,0 +1,27 @@
+minVersion: '0.6.0'
+github:
+  owner: getsentry
+  repo: sentry-javascript
+changelogPolicy: simple
+preReleaseCommand: bash scripts/craft-pre-release.sh
+targets:
+  - name: npm
+  - name: github
+    includeNames: /^sentry-.*$/
+  - name: gcs
+    includeNames: /^bundle\..*$/
+    bucket: sentry-js-sdk
+    paths:
+      - path: /{{version}}/
+        metadata:
+          cacheControl: 'public, max-age=31536000'
+  - name: registry
+    type: sdk
+    includeNames: /^sentry-browser-.*\.tgz$/
+    config:
+      canonical: 'npm:@sentry/browser'
+  - name: registry
+    type: sdk
+    includeNames: /^sentry-node-.*\.tgz$/
+    config:
+      canonical: 'npm:@sentry/node'

.gitignore

@@ -26,3 +26,4 @@ lerna-debug.log
 .rpt2_cache
 
 docs
+lint-results.json

.travis.yml

@@ -16,51 +16,48 @@ cache:
 
 matrix:
   include:
-    - name: '@sentry/packages - danger'
+    - name: '@sentry/packages - build + lint + test + codecov + danger [node v8]'
       node_js: '8'
-      script: .travis/danger.sh
-    - name: '@sentry/packages - lint'
+      script: scripts/danger.sh
+    - name: '@sentry/packages - pack and zeus upload'
       node_js: '8'
-      script: .travis/lint.sh
+      script: scripts/pack-and-upload.sh || [[ ! "$TRAVIS_BRANCH" =~ ^release/ ]]
     - name: '@sentry/packages - build and test [node v6]'
       node_js: '6'
-      script: .travis/test.sh
-    - name: '@sentry/packages - build and test [node v8]'
-      node_js: '8'
-      script: .travis/test.sh
+      script: scripts/test.sh
     - name: '@sentry/packages - build and test [node v10]'
       node_js: '10'
-      script: .travis/test.sh
+      script: scripts/test.sh
     - name: '@sentry/browser - integration tests'
       node_js: '8'
       addons:
         chrome: stable
         firefox: latest
         sauce_connect: true
-      script: .travis/integration.sh
+      script: scripts/integration.sh
     - name: 'raven-js - unit and integration tests'
       node_js: '8'
       addons:
         chrome: stable
         firefox: latest
-      script: .travis/raven-js.sh
+      script: scripts/raven-js.sh
     - name: 'raven-js - saucelabs tests'
       node_js: '8'
       addons:
         sauce_connect: true
-      script: .travis/raven-js-saucelabs.sh
+      script: scripts/raven-js-saucelabs.sh
     - name: 'raven-node [node v4]'
       node_js: '4'
-      script: .travis/raven-node.sh
+      script: scripts/raven-node.sh
     - name: 'raven-node [node v6]'
       node_js: '6'
-      script: .travis/raven-node.sh
+      script: scripts/raven-node.sh
     - name: 'raven-node [node v8]'
       node_js: '8'
-      script: .travis/raven-node.sh
+      script: scripts/raven-node.sh
     - name: 'raven-node [node v10]'
       node_js: '10'
-      script: .travis/raven-node.sh
+      script: scripts/raven-node.sh
 
 notifications:
   webhooks:

.travis/lint.sh

@@ -1,11 +1,13 @@
 bump:
 	yarn lerna version --exact --no-git-tag-version --no-push
+.PHONY: bump
 
 prepare-release:
 	yarn clean
 	yarn build
 	yarn lint
 	yarn test
+.PHONY: prepare-release
 
 publish-npm:
 	cd packages/browser; npm publish
@@ -16,18 +18,26 @@ publish-npm:
 	# cd packages/types; npm publish
 	# cd packages/typescript; npm publish
 	cd packages/utils; npm publish
+.PHONY: publish-npm
 
 publish-cdn:
 	node scripts/browser-upload-cdn.js
+.PHONY: publish-cdn
 
-publish-docs:
-	node ./node_modules/.bin/typedoc --options ./typedoc.js
+build-docs:
+	rm -rf ./docs
+	yarn typedoc --options ./typedoc.js
+.PHONY: build-docs
+
+publish-docs: build-docs
 	rm -rf /tmp/sentry-js-docs | true
 	cp -r ./docs /tmp/sentry-js-docs
 	git checkout gh-pages
 	cp -r /tmp/sentry-js-docs/* .
 	git commit -a -m "meta: Update docs"
 	git push origin gh-pages
 	git checkout master
+.PHONY: publish-docs
 
 release: bump prepare-release publish-npm publish-cdn
+.PHONY: release

Makefile

@@ -1,12 +1,44 @@
 import { exec } from 'child_process';
-import { danger, message, schedule, warn } from 'danger';
+import { danger, fail, message, schedule, warn } from 'danger';
 import { promisify } from 'util';
+import { resolve } from 'path';
+import tslint from 'danger-plugin-tslint';
+import { prettyResults } from 'danger-plugin-tslint/dist/prettyResults';
+
+const packages = ['browser', 'core', 'hub', 'minimal', 'node', 'types', 'utils'];
 
 export default async () => {
   if (!danger.github) {
     return;
   }
 
+  schedule(async () => {
+    const tsLintResult = (await Promise.all(
+      packages.map(packageName => {
+        return new Promise<string>(res => {
+          tslint({
+            lintResultsJsonPath: resolve(__dirname, 'packages', packageName, 'lint-results.json'),
+            handleResults: results => {
+              if (results.length > 0) {
+                const formattedResults = prettyResults(results);
+                res(`TSLint failed: **@sentry/${packageName}**\n\n${formattedResults}`);
+              } else {
+                res('');
+              }
+            },
+          });
+        });
+      }),
+    )).filter(str => str.length);
+    if (tsLintResult.length) {
+      tsLintResult.forEach(tsLintFail => {
+        fail(`${tsLintFail}`);
+      });
+    } else {
+      message('✅ TSLint passed');
+    }
+  });
+
   const hasChangelog = danger.git.modified_files.indexOf('CHANGELOG.md') !== -1;
   const isTrivial = (danger.github.pr.body + danger.github.pr.title).includes('#trivial');
 
@@ -16,6 +48,6 @@ export default async () => {
 
   schedule(async () => {
     const result = (await promisify(exec)('cd packages/browser; yarn size:check')).stdout;
-    message(`@sentry/browser gzip minified size: ${result.split('\n')[1]}`);
+    message(`@sentry/browser gzip'ed minified size: ${result.split('\n')[1]}`);
   });
 };

dangerfile.ts

@@ -6,6 +6,7 @@
     "clean": "lerna run --stream clean",
     "fix": "lerna run --stream --concurrency 1 fix",
     "lint": "lerna run --stream --concurrency 1 lint",
+    "lint:json": "lerna run --stream --concurrency 1 lint:tslint:json",
     "test": "lerna run --stream --concurrency 1 --sort test",
     "codecov": "codecov"
   },
@@ -30,6 +31,7 @@
     "chai": "^4.1.2",
     "codecov": "^3.0.2",
     "danger": "^4.0.2",
+    "danger-plugin-tslint": "^2.0.0",
     "jest": "^22.4.3",
     "karma-sinon": "^1.0.5",
     "lerna": "3.4.0",

package.json

@@ -55,6 +55,7 @@
     "lint": "run-s lint:prettier lint:tslint",
     "lint:prettier": "prettier-check '{src,test}/**/*.ts'",
     "lint:tslint": "tslint -t stylish -p .",
+    "lint:tslint:json": "tslint --format json -p . | tee lint-results.json",
     "fix": "run-s fix:tslint fix:prettier",
     "fix:prettier": "prettier --write '{src,test}/**/*.ts'",
     "fix:tslint": "tslint --fix -t stylish -p .",

packages/browser/package.json

@@ -36,6 +36,7 @@
     "lint": "run-s lint:prettier lint:tslint",
     "lint:prettier": "prettier-check '{src,test}/**/*.ts'",
     "lint:tslint": "tslint -t stylish -p .",
+    "lint:tslint:json": "tslint --format json -p . | tee lint-results.json",
     "fix": "run-s fix:tslint fix:prettier",
     "fix:prettier": "prettier --write '{src,test}/**/*.ts'",
     "fix:tslint": "tslint --fix -t stylish -p .",

packages/core/package.json

@@ -34,6 +34,7 @@
     "lint": "run-s lint:prettier lint:tslint",
     "lint:prettier": "prettier-check '{src,test}/**/*.ts'",
     "lint:tslint": "tslint -t stylish -p .",
+    "lint:tslint:json": "tslint --format json -p . | tee lint-results.json",
     "fix": "run-s fix:tslint fix:prettier",
     "fix:prettier": "prettier --write '{src,test}/**/*.ts'",
     "fix:tslint": "tslint --fix -t stylish -p .",