feat(v8): Remove deprecated span.isSuccess method (#10699)

ref #10677

deprecation PR: #10213

Author: AbhiPrasad

packages/core/src/tracing/sentrySpan.ts

@@ -503,15 +503,6 @@ export class SentrySpan implements SpanInterface {
     return this;
   }
 
-  /**
-   * @inheritDoc
-   *
-   * @deprecated Use `spanToJSON(span).status === 'ok'` instead.
-   */
-  public isSuccess(): boolean {
-    return this._status === 'ok';
-  }
-
   /**
    * @inheritDoc
    *

packages/tracing/test/span.test.ts

@@ -123,31 +123,6 @@ describe('SentrySpan', () => {
       expect(span.tags['http.status_code']).toBe('404');
       expect(span.data['http.response.status_code']).toBe(404);
     });
-
-    // TODO (v8): Remove
-    test('isSuccess', () => {
-      const span = new SentrySpan({});
-      expect(span.isSuccess()).toBe(false);
-      expect(spanToJSON(span).status).not.toBe('ok');
-      span.setHttpStatus(200);
-      expect(span.isSuccess()).toBe(true);
-      expect(spanToJSON(span).status).toBe('ok');
-      span.setStatus('permission_denied');
-      expect(span.isSuccess()).toBe(false);
-      expect(spanToJSON(span).status).not.toBe('ok');
-      span.setHttpStatus(0);
-      expect(span.isSuccess()).toBe(false);
-      expect(spanToJSON(span).status).not.toBe('ok');
-      span.setHttpStatus(-1);
-      expect(span.isSuccess()).toBe(false);
-      expect(spanToJSON(span).status).not.toBe('ok');
-      span.setHttpStatus(99);
-      expect(span.isSuccess()).toBe(false);
-      expect(spanToJSON(span).status).not.toBe('ok');
-      span.setHttpStatus(100);
-      expect(span.isSuccess()).toBe(true);
-      expect(spanToJSON(span).status).toBe('ok');
-    });
   });
 
   describe('toTraceparent', () => {

packages/types/src/span.ts

@@ -365,13 +365,6 @@ export interface Span extends Omit<SpanContext, 'op' | 'status' | 'origin'> {
    */
   startChild(spanContext?: Pick<SpanContext, Exclude<keyof SpanContext, 'sampled' | 'traceId' | 'parentSpanId'>>): Span;
 
-  /**
-   * Determines whether span was successful (HTTP200)
-   *
-   * @deprecated Use `spanToJSON(span).status === 'ok'` instead.
-   */
-  isSuccess(): boolean;
-
   /**
    * Return a traceparent compatible header string.
    * @deprecated Use `spanToTraceHeader()` instead.