fix: Respect breadcrumbs sentry:false option (#2499)

kamilogorek · web-flow · commit 39af3b40e63e · 2020-03-16T14:00:04.000+01:00
diff --git a/packages/browser/src/integrations/breadcrumbs.ts b/packages/browser/src/integrations/breadcrumbs.ts
@@ -153,7 +153,7 @@ export class Breadcrumbs implements Integration {
     }
 
     // We only capture issued sentry requests
-    if (handlerData.xhr.__sentry_own_request__) {
+    if (this._options.sentry && handlerData.xhr.__sentry_own_request__) {
       addSentryBreadcrumb(handlerData.args[0]);
     }
   }
@@ -169,8 +169,7 @@ export class Breadcrumbs implements Integration {
 
     const client = getCurrentHub().getClient<BrowserClient>();
     const dsn = client && client.getDsn();
-
-    if (dsn) {
+    if (this._options.sentry && dsn) {
       const filterUrl = new API(dsn).getStoreEndpoint();
       // if Sentry key appears in URL, don't capture it as a request
       // but rather as our own 'sentry' type breadcrumb

Original file line number	Diff line number	Diff line change
`@@ -153,7 +153,7 @@ export class Breadcrumbs implements Integration {`
`153`	`153`	`}`
`154`	`154`
`155`	`155`	`// We only capture issued sentry requests`
`156`		`- if (handlerData.xhr.__sentry_own_request__) {`
	`156`	`+ if (this._options.sentry && handlerData.xhr.__sentry_own_request__) {`
`157`	`157`	`addSentryBreadcrumb(handlerData.args[0]);`
`158`	`158`	`}`
`159`	`159`	`}`
`@@ -169,8 +169,7 @@ export class Breadcrumbs implements Integration {`
`169`	`169`
`170`	`170`	`const client = getCurrentHub().getClient<BrowserClient>();`
`171`	`171`	`const dsn = client && client.getDsn();`
`172`		`-`
`173`		`- if (dsn) {`
	`172`	`+ if (this._options.sentry && dsn) {`
`174`	`173`	`const filterUrl = new API(dsn).getStoreEndpoint();`
`175`	`174`	`// if Sentry key appears in URL, don't capture it as a request`
`176`	`175`	`// but rather as our own 'sentry' type breadcrumb`