fix(serverless): Re-add missing modules in Node AWS Lambda Layer (#4982)

This PR fixes the AWS Lambda layer in @sentry/serverless.

The problem was caused by changes introduced in #4882.

Some unintended consequences of these changes were:

- By centralising most .npmignore files, npm-packlist did not find all the necessary (but also unnecessary) files when creating the list of files that should end up in the lambda layer Zip file. Due to the missing .npmignore files, it resorted to .gitignore which ignores generated JS files. This PR re-adds local .npmignore files in the dependencies of @sentry/serverless to fix this.

- @sentry/tracing is a special case where we need to execute prepack.ts also after building. The call to prepack was missing the --bundles flag, resulting in a weird directory structure. This PR adds the flag and adjusts the sideEffects entry we need for our integration tests.

As a hotfix, this PR ensures further that the directory structure in the Lambda layer conforms to the NODE_OPTIONS environment variable set by Sentry

Author: Lms24

packages/minimal/.npmignore

@@ -0,0 +1,11 @@
+# The paths in this file are specified so that they align with the file structure in `./build` after this file is copied
+# into it by the prepack script `scripts/prepack.ts`.
+
+*
+
+# TODO remove bundles (which in the tarball are inside `build`) in v7
+!/build/**/*
+
+!/dist/**/*
+!/esm/**/*
+!/types/**/*

packages/node/.npmignore

@@ -0,0 +1,11 @@
+# The paths in this file are specified so that they align with the file structure in `./build` after this file is copied
+# into it by the prepack script `scripts/prepack.ts`.
+
+*
+
+# TODO remove bundles (which in the tarball are inside `build`) in v7
+!/build/**/*
+
+!/dist/**/*
+!/esm/**/*
+!/types/**/*

packages/serverless/scripts/build-awslambda-layer.js

@@ -144,6 +144,13 @@ async function main() {
   const version = serverlessPackage.version;
   const zipFilename = `sentry-node-serverless-${version}.zip`;
 
+  try {
+    fs.symlinkSync(path.resolve(destRoot, 'build', 'dist'), path.resolve(destRoot, 'dist'));
+    fs.symlinkSync(path.resolve(destRoot, 'build', 'esm'), path.resolve(destRoot, 'esm'));
+  } catch (error) {
+    console.error(error);
+  }
+
   try {
     fs.unlinkSync(path.resolve(dist, zipFilename));
   } catch (error) {

packages/tracing/.npmignore

@@ -0,0 +1,11 @@
+# The paths in this file are specified so that they align with the file structure in `./build` after this file is copied
+# into it by the prepack script `scripts/prepack.ts`.
+
+*
+
+# TODO remove bundles (which in the tarball are inside `build`) in v7
+!/build/**/*
+
+!/dist/**/*
+!/esm/**/*
+!/types/**/*

packages/tracing/package.json

@@ -29,7 +29,7 @@
     "jsdom": "^16.2.2"
   },
   "scripts": {
-    "build": "run-p build:cjs build:esm build:types build:bundle && ts-node ../../scripts/prepack.ts #necessary for integration tests",
+    "build": "run-p build:cjs build:esm build:types build:bundle && ts-node ../../scripts/prepack.ts --bundles #necessary for integration tests",
     "build:bundle": "rollup --config",
     "build:cjs": "tsc -p tsconfig.cjs.json",
     "build:dev": "run-p build:cjs build:esm build:types",
@@ -82,8 +82,8 @@
   "sideEffects": [
     "./dist/index.js",
     "./esm/index.js",
-    "./npm/dist/index.js",
-    "./npm/esm/index.js",
+    "./build/npm/dist/index.js",
+    "./build/npm/esm/index.js",
     "./src/index.ts"
   ]
 }

packages/types/.npmignore

@@ -0,0 +1,11 @@
+# The paths in this file are specified so that they align with the file structure in `./build` after this file is copied
+# into it by the prepack script `scripts/prepack.ts`.
+
+*
+
+# TODO remove bundles (which in the tarball are inside `build`) in v7
+!/build/**/*
+
+!/dist/**/*
+!/esm/**/*
+!/types/**/*

packages/utils/.npmignore

@@ -0,0 +1,11 @@
+# The paths in this file are specified so that they align with the file structure in `./build` after this file is copied
+# into it by the prepack script `scripts/prepack.ts`.
+
+*
+
+# TODO remove bundles (which in the tarball are inside `build`) in v7
+!/build/**/*
+
+!/dist/**/*
+!/esm/**/*
+!/types/**/*