feat: capture exception breadcrumbs as we do in raven-js (#461)

Author: kamilogorek

lib/client.js

@@ -232,8 +232,12 @@ extend(Raven.prototype, {
     kwargs.user = extend({}, globalContext.user, domainContext.user, kwargs.user);
     kwargs.tags = extend({}, globalContext.tags, domainContext.tags, kwargs.tags);
     kwargs.extra = extend({}, globalContext.extra, domainContext.extra, kwargs.extra);
+    // Perform a shallow copy of breadcrums to not send one that we'll capture below through as well
     kwargs.breadcrumbs = {
-      values: domainContext.breadcrumbs || globalContext.breadcrumbs || []
+      values:
+        (domainContext.breadcrumbs && domainContext.breadcrumbs.slice()) ||
+        (globalContext.breadcrumbs && globalContext.breadcrumbs.slice()) ||
+        []
     };
 
     /*
@@ -288,6 +292,15 @@ extend(Raven.prototype, {
       kwargs = this.dataCallback(kwargs);
     }
 
+    // Capture breadcrumb before sending it, as we also want to have it even when
+    // it was dropped due to sampleRate or shouldSendCallback
+    this.captureBreadcrumb({
+      category: 'sentry',
+      message: kwargs.message,
+      event_id: kwargs.event_id,
+      level: kwargs.level || 'error' // presume error unless specified
+    });
+
     var shouldSend = true;
     if (!this._enabled) shouldSend = false;
     if (this.shouldSendCallback && !this.shouldSendCallback(kwargs)) shouldSend = false;

test/raven.client.js

@@ -1212,6 +1212,32 @@ describe('raven.Client', function() {
     });
   });
 
+  it('should captureBreadcrumb with processed exception', function(done) {
+    var calls = 0;
+    client = new raven.Client(dsn, {
+      shouldSendCallback: function(data) {
+        // Don't test first call, as there's no breadcrumbs there
+        if (calls === 0) {
+          calls += 1;
+          return false;
+        }
+
+        if (calls === 1) {
+          data.breadcrumbs.values.length.should.equal(1);
+          data.breadcrumbs.values[0].category.should.equal('sentry');
+          data.breadcrumbs.values[0].message.should.equal('Error: foo');
+          data.breadcrumbs.values[0].level.should.equal('error');
+          client.uninstall();
+          done();
+        }
+      }
+    });
+
+    client.install();
+    client.captureException(new Error('foo'));
+    client.captureException(new Error('bar'));
+  });
+
   describe('#setContext', function() {
     afterEach(function() {
       process.domain && process.domain.exit();
@@ -1517,7 +1543,7 @@ describe('raven.Client', function() {
         });
       });
 
-      it('should not capture breadcrumbs for requests to sentry', function(done) {
+      it('should not capture breadcrumbs for requests to sentry, but should capture exception call itself', function(done) {
         var scope = nock('https://app.getsentry.com')
           .filteringRequestBody(/.*/, '*')
           .post('/api/269/store/', '*')
@@ -1527,7 +1553,8 @@ describe('raven.Client', function() {
           client.captureException(new Error('test'), function() {
             // need to wait a tick because the response handler that captures the breadcrumb might run after this one
             setTimeout(function() {
-              client.getContext().should.not.have.key('breadcrumbs');
+              client.getContext().breadcrumbs.length.should.equal(1);
+              client.getContext().breadcrumbs[0].category.should.equal('sentry');
               scope.done();
               done();
             }, 0);